Fix incorrect serde(rename) field mapping in ActiveModel::from_json#2855
Open
Huliiiiii wants to merge 2 commits intoSeaQL:masterfrom
Open
Fix incorrect serde(rename) field mapping in ActiveModel::from_json#2855Huliiiiii wants to merge 2 commits intoSeaQL:masterfrom
Huliiiiii wants to merge 2 commits intoSeaQL:masterfrom
Conversation
Huliiiiii
force-pushed
the
rename-all
branch
from
fcc7095 to
e5c9be4
Compare
Huliiiiii
changed the title
Huliiiiii
commented
Feb 18, 2026
| /// Create ActiveModel from a JSON value | ||
| #[cfg(feature = "with-json")] | ||
| fn from_json(mut json: serde_json::Value) -> Result<Self, DbErr> | ||
| fn from_json(json: serde_json::Value) -> Result<Self, DbErr> |
Member
Author
There was a problem hiding this comment.
A better solution is to implement from_json in the macro, which make code cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2854