peerbanhelper: Add version 9.3.8

[WordlessEcho]

Closes #15752

• Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
• I have read the Contributing Guide

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[WordlessEcho]

Waiting ScoopInstaller/Java#577

[github-actions]

All changes look good.

Wait for review from human collaborators.

PeerBanHelper

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[WordlessEcho]

/verify

[github-actions]

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

peerbanhelper

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[WordlessEcho]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

peerbanhelper

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[WordlessEcho]

/verify

[github-actions]

All changes look good.

Wait for review from human collaborators.

peerbanhelper

• Lint
• Description
• License
• Hashes
• Checkver
• Autoupdate

Check the full log for details.

[z-Fng]

Why not use the JRE self-contained releases, but instead make this package so complicated?

https://github.com/PBH-BTN/PeerBanHelper/releases/download/v9.3.11/PeerBanHelper_Windows_9.3.11_Portable.zip

[z-Fng]

Thanks for your contribution! Closing this PR in favor of #17637.

[WordlessEcho]

I thought that separating dependencies is a good engineering practice.

[z-Fng]

I thought that separating dependencies is a good engineering practice.

For portable packages, I personally always prefer using .NET/JRE self-contained versions, if provided. Separating dependencies is indeed a good idea, but it would make things very complicated in this case. Moreover, these dependencies change periodically, making these manifests difficult to maintain.