Skip to content

Conversation

@SorYoshino
Copy link
Contributor

@SorYoshino SorYoshino commented Dec 22, 2025

Summary

Improves the ios-webkit-debug-proxy manifest by correcting license metadata and making version detection more reliable through explicit GitHub Releases API querying and asset-based filtering.

Related issues or pull requests

Changes

  • Update the license field to reflect the complete set of licenses included in the distribution
  • Replace the shorthand checkver: github with an explicit GitHub Releases API endpoint

Notes

  • The license information in the GitHub project is outdated; the currently applicable licenses can be found in the $dir directory.

    ┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
    └─> Get-ChildItem -Path D:\Software\Scoop\Local\apps\ios-webkit-debug-proxy\current -Filter '*.txt'
    
            Directory: D:\Software\Scoop\Local\apps\ios-webkit-debug-proxy\current
    
    
    Mode                LastWriteTime         Length Name
    ----                -------------         ------ ----
    -a---         2024/5/28     11:43          11358 󰈙  COPYING.APACHEv2.0.txt
    -a---         2024/5/28     11:43          18092 󰈙  COPYING.GPLv2.txt
    -a---         2024/5/28     11:43          26434 󰈙  COPYING.LGPLv2.1.txt
    -a---         2024/5/28     11:43           6128 󰈙  COPYING.OPENSSL.txt
    

Testing

The test results are as follows:
┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> .\checkver.ps1 -App ios-webkit-debug-proxy -Dir 'D:\Temporary\Software\Microsoft\Windows Sandbox\Repositories\Scoop\Buckets\Extras\bucket' -f
ios-webkit-debug-proxy: 1.9.1 (scoop version is 1.9.1)
Forcing autoupdate!
Autoupdating ios-webkit-debug-proxy
DEBUG[1766433496] [$updatedProperties] = [url hash] -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:491:5
DEBUG[1766433496] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1766433496] $substitutions.$matchTag                      v1.9.1
DEBUG[1766433496] $substitutions.$version                       1.9.1
DEBUG[1766433496] $substitutions.$cleanVersion                  191
DEBUG[1766433496] $substitutions.$minorVersion                  9
DEBUG[1766433496] $substitutions.$basenameNoExt                 ios-webkit-debug-proxy-1.9.1-win64-bin
DEBUG[1766433496] $substitutions.$majorVersion                  1
DEBUG[1766433496] $substitutions.$dashVersion                   1-9-1
DEBUG[1766433496] $substitutions.$buildVersion
DEBUG[1766433496] $substitutions.$matchHead                     1.9.1
DEBUG[1766433496] $substitutions.$underscoreVersion             1_9_1
DEBUG[1766433496] $substitutions.$matchTail
DEBUG[1766433496] $substitutions.$preReleaseVersion             1.9.1
DEBUG[1766433496] $substitutions.$dotVersion                    1.9.1
DEBUG[1766433496] $substitutions.$patchVersion                  1
DEBUG[1766433496] $substitutions.$match1                        1.9.1
DEBUG[1766433496] $substitutions.$baseurl                       https://github.com/google/ios-webkit-debug-proxy/releases/download/v1.9.1
DEBUG[1766433496] $substitutions.$urlNoExt                      https://github.com/google/ios-webkit-debug-proxy/releases/download/v1.9.1/ios-webkit-debug-proxy-1.9.1-win64-bin
DEBUG[1766433496] $substitutions.$url                           https://github.com/google/ios-webkit-debug-proxy/releases/download/v1.9.1/ios-webkit-debug-proxy-1.9.1-win64-bin.zip
DEBUG[1766433496] $substitutions.$basename                      ios-webkit-debug-proxy-1.9.1-win64-bin.zip
DEBUG[1766433496] $hashfile_url = $null -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:224:5
DEBUG[1766433497] $jsonpath = $..assets[?(@.browser_download_url == 'https://github.com/google/ios-webkit-debug-proxy/releases/download/v1.9.1/ios-webkit-debug-proxy-1.9.1-win64-bin.zip')].digest -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:132:5
Could not find hash in https://api.github.com/repos/google/ios-webkit-debug-proxy/releases
Downloading ios-webkit-debug-proxy-1.9.1-win64-bin.zip to compute hashes!
Loading ios-webkit-debug-proxy-1.9.1-win64-bin.zip from cache
Computed hash: f1c7a62ae956ea9ad6fb3ae4cf13f3df882b0d52a7fcc34a0e4e728e0e364fed
Writing updated ios-webkit-debug-proxy manifest
  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Chores
    • Updated package license information to reflect multiple licensing terms
    • Enhanced version detection and update mechanism for improved reliability

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Walkthrough

This pull request updates the ios-webkit-debug-proxy manifest file with changes to the license declaration, version checking mechanism, and release URL configuration. The checkver field transitions from a simple GitHub reference to a structured GitHub API endpoint with JSONPath filtering and regex extraction, while autoupdate URLs are modified to use dynamic release tag matching.

Changes

Cohort / File(s) Summary
Manifest version & license updates
bucket/ios-webkit-debug-proxy.json
License field expanded from BSD-3-Clause to Apache-2.0, GPL-2.0-or-later, LGPL-2.1-or-later, OpenSSL; checkver converted to GitHub API endpoint with JSONPath filtering for non-prerelease assets matching win64 pattern and regex tag extraction; autoupdate 64-bit URL updated to use $matchTag instead of v$version.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify GitHub API endpoint and JSONPath syntax are correct for filtering releases
  • Confirm regex pattern properly extracts version tags with optional v prefix
  • Validate that $matchTag replacement in URL aligns with the regex capture group and expected release asset naming

Possibly related PRs

Suggested labels

review-needed

Suggested reviewers

  • z-Fng

Poem

🐰 A manifest so fine, with licenses in a line,
Checkver's now precise, via JSON's grand device,
Release tags matched true, with regex magic too—
Version checking hops forward, clarity restored! 🎯

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description includes all required sections: summary, related issues, changes, notes, testing details, and confirms the conventional PR title format checkbox.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly summarizes the main changes: fixing checkver configuration and updating the license field in the ios-webkit-debug-proxy manifest.
✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ios-webkit-debug-proxy

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1312243 and 22dc388.

📒 Files selected for processing (1)
  • bucket/ios-webkit-debug-proxy.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.

Applied to files:

  • bucket/ios-webkit-debug-proxy.json
📚 Learning: 2025-11-29T22:02:34.868Z
Learnt from: Ra2-IFV
Repo: ScoopInstaller/Extras PR: 16672
File: bucket/chromium-clang.json:12-12
Timestamp: 2025-11-29T22:02:34.868Z
Learning: In the chromium-clang.json manifest (bucket/chromium-clang.json), the extract_dir value "chrome-win32" is a fixed name determined by the upstream Chromium_Clang archive structure and should not be changed, even though the manifest targets 64-bit architecture.

Applied to files:

  • bucket/ios-webkit-debug-proxy.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (1)
bucket/ios-webkit-debug-proxy.json (1)

21-21: LGTM! Proper use of $matchTag for release URLs.

The change from v$version to $matchTag correctly handles release tags that include the "v" prefix. Since the regex captures the full tag (including optional "v") in the named group "tag", using $matchTag ensures the download URL correctly references the GitHub release tag as it appears in the repository.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng changed the title ios-webkit-debug-proxy: Fix checkver, improve license accuracy ios-webkit-debug-proxy: Fix checkver, update license Jan 3, 2026
@z-Fng z-Fng merged commit ddf352a into ScoopInstaller:master Jan 3, 2026
4 checks passed
@SorYoshino SorYoshino deleted the ios-webkit-debug-proxy branch January 3, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants