mupdf@1.27.0: fixes checkver, autoupdate, main shortcut #16867
Conversation
WalkthroughThe PR updates the mupdf manifest file with revised download URLs pointing to casper.mupdf.com, changes the executable shortcut from mupdf.exe to mupdf-gl.exe, adds a vcredist2022 suggestion, and refines version checking and hash extraction patterns and URLs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. mupdf
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bucket/mupdf.json (1)
1-41: Consider adding a notes field about data storage.The PR objectives mention that mupdf stores data outside Scoop in
~/.mupdf.history. Consider adding a "notes" field to inform users about this persistent data location.🔎 Suggested addition
After the homepage or license field, you could add:
"notes": "MuPDF stores history data in ~/.mupdf.history outside of the Scoop directory."
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/mupdf.json
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
📚 Learning: 2025-10-15T11:54:31.320Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16341
File: bucket/foxit-pdf-reader.json:47-50
Timestamp: 2025-10-15T11:54:31.320Z
Learning: In bucket/foxit-pdf-reader.json and bucket/foxit-reader.json, the checkver script uses MaximumRedirection 1 (not 0) for Invoke-WebRequest to properly handle Foxit's backend redirect behavior when parsing the Location header for version detection.
Applied to files:
bucket/mupdf.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Applied to files:
bucket/mupdf.json
📚 Learning: 2025-10-16T15:59:21.258Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
Applied to files:
bucket/mupdf.json
📚 Learning: 2025-09-05T09:41:52.653Z
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
Applied to files:
bucket/mupdf.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (5)
bucket/mupdf.json (5)
20-25: Good change to use the primary viewer executable.Switching the shortcut from
mupdf.exetomupdf-gl.exeis appropriate if the GL version is the primary viewer. This prevents Windows from recommending the legacy executable while keeping both binaries accessible via the command line.
11-11: No action needed. The casper.mupdf.com download source is officially maintained by Artifex Software and is a stable, approved distribution channel. The URL is valid and will remain reliable for future releases.
6-8: Clarify vcredist2022 dependency classification.The vcredist2022 entry is marked as optional ("suggest") rather than required ("depends"). While third-party mupdf bindings document Visual C++ Redistributable as a requirement, official mupdf documentation does not explicitly list it as a runtime dependency. Verify whether mupdf executables will fail without vcredist2022 installed or if it already satisfies these dependencies elsewhere, then adjust the classification accordingly.
27-28: Verify the checkver URL change works with MuPDF's releases page.The regex change to
[0-9.]+correctly excludes release candidates (like 1.27.0-rc1) by matching only numeric versions with dots, which addresses the known issue with RC extractions. The URL update tohttps://mupdf.com/releases?product=MuPDFfollows patterns used in similar package manifests. Confirm that this specific URL+query combination returns the expected release file listing when accessed by the checkver tool.
30-40: Hash extraction pattern is valid and will successfully extract SHA256 hashes.The releases page returns JSON-formatted data with SHA256 hashes for each file. The regex pattern
$basename[^}]+SHA256\":\"(\\w+)\"correctly matches the JSON structure and will extract the hash value for the Windows download (f3e60b630453301914e52fb8ec001f6ab56cdb90daf39e533deae3ff214fcff8 for version 1.27.0). The autoupdate configuration is functional as implemented.
1 participant
extras/vcredist2022Replaces shortcut with
mupdf-gl.exe, since:Furthermore:
Closes: MuPDf cannot be updated from 1.17.0-rc1 to 1.17.0. #3992
Verified there are no other open issues for this application in scoop
Verified there are no other open pull requests for this application
Use conventional PR title
I have read the Contributing Guide
Follows general order of fields and ran
.\bin\formatjson.ps1Tab width 4 spaces
Checkver OK
Autoupdate OK:
Confirmed Virustotal OK
https://www.virustotal.com/gui/file/f3e60b630453301914e52fb8ec001f6ab56cdb90daf39e533deae3ff214fcff8
Tests
Observations
Stores data outside of scoop:
~\.mupdf.historySummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.