audiobookconverter: Add version 6.6.8 #16844
Conversation
WalkthroughAdded a new Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-10-19T13:58:23.389ZApplied to files:
📚 Learning: 2025-10-16T13:55:04.356ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with audiobookconverter
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/audiobookconverter.json(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Applied to files:
bucket/audiobookconverter.json
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.
Applied to files:
bucket/audiobookconverter.json
📚 Learning: 2025-11-29T22:02:34.868Z
Learnt from: Ra2-IFV
Repo: ScoopInstaller/Extras PR: 16672
File: bucket/chromium-clang.json:12-12
Timestamp: 2025-11-29T22:02:34.868Z
Learning: In the chromium-clang.json manifest (bucket/chromium-clang.json), the extract_dir value "chrome-win32" is a fixed name determined by the upstream Chromium_Clang archive structure and should not be changed, even though the manifest targets 64-bit architecture.
Applied to files:
bucket/audiobookconverter.json
🪛 GitHub Actions: Pull Requests
bucket/audiobookconverter.json
[error] 1-1: Autoupdate: Version match fail. Checkver and Autoupdate both reported failure during manifest checks.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (2)
bucket/audiobookconverter.json (2)
12-12: Theextract_dirvalue "AudioBookConverter" is correctly set and matches the actual archive structure.
6-11: No changes needed—the 64-bit-only architecture is correct.The manifest correctly specifies only 64-bit architecture. AudioBookConverter runs on 64-bit version of Windows, and no 32-bit builds are available.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
bucket/audiobookconverter.json (1)
19-23: Simplify checkver to use the recommendedgithubfield approach.The current API-based checkver with jsonpath works but is more complex than needed. The past review already recommended a simpler approach using the
githubfield with a custom regex. Additionally, the regex has two capture groups when only the first is used (both should contain the same version anyway).🔎 Recommended simplification matching past review guidance
- "checkver": { - "url": "https://api.github.com/repos/yermak/AudioBookConverter/releases", - "jsonpath": "$..browser_download_url", - "regex": "download/version_([\\d.]+)/AudioBookConverter-Portable-([\\d.]+)" - }, + "checkver": { + "github": "https://github.com/yermak/AudioBookConverter", + "regex": "version_([\\d.]+)" + },This approach checks GitHub tags directly with a single capture group, making it simpler and more maintainable.
Based on past review comments suggesting this exact pattern.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/audiobookconverter.json(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds in recent versions uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format. This was confirmed by a working 10.0.0 update with valid hash.
Learnt from: Gitoffthelawn
Repo: ScoopInstaller/Extras PR: 16106
File: bucket/czkawka-gui.json:25-25
Timestamp: 2025-09-05T09:41:52.653Z
Learning: For czkawka-gui manifests in Scoop Extras, the correct upstream filename pattern for Windows GUI builds uses "gtk46" (without underscore), not "gtk_46" (with underscore). The autoupdate URL should use "windows_czkawka_gui_gtk46.zip" format.
Learnt from: SorYoshino
Repo: ScoopInstaller/Extras PR: 16333
File: bucket/potplayer.json:55-64
Timestamp: 2025-10-14T11:15:55.229Z
Learning: In PotPlayer manifests (bucket/potplayer.json), PotPlayer*.ini files (PotPlayer.ini, PotPlayer64.ini, PotPlayerMini.ini, PotPlayerMini64.ini) work correctly with Scoop's hard links and don't need special handling in post_install scripts.
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Applied to files:
bucket/audiobookconverter.json
📚 Learning: 2025-11-29T22:02:34.868Z
Learnt from: Ra2-IFV
Repo: ScoopInstaller/Extras PR: 16672
File: bucket/chromium-clang.json:12-12
Timestamp: 2025-11-29T22:02:34.868Z
Learning: In the chromium-clang.json manifest (bucket/chromium-clang.json), the extract_dir value "chrome-win32" is a fixed name determined by the upstream Chromium_Clang archive structure and should not be changed, even though the manifest targets 64-bit architecture.
Applied to files:
bucket/audiobookconverter.json
📚 Learning: 2025-10-16T13:42:43.224Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugviewpp.json:14-21
Timestamp: 2025-10-16T13:42:43.224Z
Learning: In the DebugViewPP project (CobaltFusion/DebugViewPP), the executable name changed from "DebugView++.exe" (in v1.8.0.103 and earlier) to "Debugviewpp.exe" (in v1.9.0.28 and later). The manifest bucket/debugviewpp.json correctly uses "Debugviewpp.exe" for current versions.
Applied to files:
bucket/audiobookconverter.json
📚 Learning: 2025-10-16T13:55:04.356Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/debugtron.json:18-25
Timestamp: 2025-10-16T13:55:04.356Z
Learning: In Scoop manifests, the `checkver.github` field must be a full URI (e.g., `https://github.com/owner/repo`), not just `owner/repo`. The schema defines it with `"format": "uri"`.
Applied to files:
bucket/audiobookconverter.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (3)
bucket/audiobookconverter.json (3)
6-11: LGTM!The architecture block is correctly structured with the download URL matching the upstream tag pattern (
version_6.6.8) and SHA-256 hash provided.
13-18: LGTM!The shortcut definition is correctly formatted and provides a user-friendly display name.
24-30: LGTM!The autoupdate configuration correctly uses
$versionsubstitution to match the upstream release URL pattern. The absence of an explicit hash field is acceptable, as Scoop will automatically calculate the hash from the downloaded file.
|
|
All changes look good. Wait for review from human collaborators. audiobookconverter
|
.\bin\checkver.ps1 -App <package> -f
.\bin\formatjson.ps1 -App <package>
scoop install "C:\Users\username\Desktop\pr\<package>.json" -a 64bit
scoop install "C:\Users\username\Desktop\pr\<package>.json" -a 32bit
scoop install "C:\Users\username\Desktop\pr\<package>.json" -a arm64 |
|
/verify |
|
All changes look good. Wait for review from human collaborators. audiobookconverter
|
…and update The `.zip` installer will crashes instantly. See yermak/AudioBookConverter#715.
|
/verify |
|
All changes look good. Wait for review from human collaborators. audiobookconverter
|
Please change the homepage to
Please change the license to Why not simply choose In addition, An example of the revised version is provided below:┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> jq '{checkver, autoupdate}' 'D:\Download\Others\Aria2\Zertw\Test\Test\SourceDir\AudioBookConverter\test.json'
{
"checkver": {
"github": "https://github.com/yermak/AudioBookConverter",
"regex": "tag/version_([\\d.]+)(?=\")"
},
"autoupdate": {
"architecture": {
"64bit": {
"url": "https://github.com/yermak/AudioBookConverter/releases/download/version_$version/AudioBookConverter-Portable-$version.zip"
}
}
}
}
┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> .\checkver.ps1 -App 'D:\Download\Others\Aria2\Zertw\Test\Test\SourceDir\AudioBookConverter\test.json' -f
test: 6.6.8 (scoop version is 6.6.8)
Forcing autoupdate!
Autoupdating test
DEBUG[1766830875] [$updatedProperties] = [url hash] -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:491:5
DEBUG[1766830875] $substitutions (hashtable) -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:221:5
DEBUG[1766830875] $substitutions.$matchTail
DEBUG[1766830875] $substitutions.$match1 6.6.8
DEBUG[1766830875] $substitutions.$dashVersion 6-6-8
DEBUG[1766830875] $substitutions.$preReleaseVersion 6.6.8
DEBUG[1766830875] $substitutions.$patchVersion 8
DEBUG[1766830875] $substitutions.$baseurl https://github.com/yermak/AudioBookConverter/releases/download/version_6.6.8
DEBUG[1766830875] $substitutions.$urlNoExt https://github.com/yermak/AudioBookConverter/releases/download/version_6.6.8/AudioBookConverter-Portable-6.6.8
DEBUG[1766830875] $substitutions.$url https://github.com/yermak/AudioBookConverter/releases/download/version_6.6.8/AudioBookConverter-Portable-6.6.8.zip
DEBUG[1766830875] $substitutions.$matchHead 6.6.8
DEBUG[1766830875] $substitutions.$minorVersion 6
DEBUG[1766830875] $substitutions.$basename AudioBookConverter-Portable-6.6.8.zip
DEBUG[1766830875] $substitutions.$majorVersion 6
DEBUG[1766830875] $substitutions.$underscoreVersion 6_6_8
DEBUG[1766830875] $substitutions.$cleanVersion 668
DEBUG[1766830875] $substitutions.$buildVersion
DEBUG[1766830875] $substitutions.$dotVersion 6.6.8
DEBUG[1766830875] $substitutions.$version 6.6.8
DEBUG[1766830875] $substitutions.$basenameNoExt AudioBookConverter-Portable-6.6.8
DEBUG[1766830875] $hashfile_url = $null -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:224:5
DEBUG[1766830876] $jsonpath = $..assets[?(@.browser_download_url == 'https://github.com/yermak/AudioBookConverter/releases/download/version_6.6.8/AudioBookConverter-Portable-6.6.8.zip')].digest -> D:\Software\Scoop\Local\apps\scoop\current\lib\autoupdate.ps1:132:5
Found: fc333346d5ad35e6b6cf12be23ffdb00ef7bada48b287f8e702cb49e7d996dad using Github Mode
Writing updated test manifest
┏[ D:\Software\Scoop\Local\apps\scoop\current\bin][ master ≡]
└─> scoop install 'D:\Download\Others\Aria2\Zertw\Test\Test\SourceDir\AudioBookConverter\test.json'
Installing 'test' (6.6.8) [64bit] from 'D:\Download\Others\Aria2\Zertw\Test\Test\SourceDir\AudioBookConverter\test.json'
Starting download with aria2 ...
Download: Download Results:
Download: gid |stat|avg speed | %|path/URI
Download: ======+====+===========+===+===================================================
Download: d61711|OK | 9.0MiB/s|100|D:/Software/Scoop/Local/cache/test#6.6.8#06e7c71.zip
Download: Status Legend:
Download: (OK):download completed.
Checking hash of AudioBookConverter-Portable-6.6.8.zip ... ok.
Extracting AudioBookConverter-Portable-6.6.8.zip ... done.
Linking D:\Software\Scoop\Local\apps\test\current => D:\Software\Scoop\Local\apps\test\6.6.8
Creating shortcut for Audio Book Converter (AudioBookConverter.exe)
'test' (6.6.8) was installed successfully! |
|
Thanks for your reminder and guidance!
I tried install it from .zip at first, but it crashes instantly on my PC. See yermak/AudioBookConverter#715. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. audiobookconverter
|
z-Fng
left a comment
z-Fng
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
The manifest will update automatically as the package updates, as long as the upstream releases new packages that follow the same pattern defined in the manifest. If there are any other changes, feel free to submit a PR.
|
Thanks for your reminder! |
3 participants
Closes #16838
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.