Skip to content

Conversation

@haussmann
Copy link
Contributor

@haussmann haussmann commented Dec 17, 2025

Recommendation to deprecate Basecamp 2, because:

  • Basecamp switched to version 4 at least since September 2022 (source)
  • Basecamp (4) switched to a portable web app based solution for Windows (source)
  • Download links, checkver and autoupdate are no longer working

Relates to #16379

Summary by CodeRabbit

  • Documentation
    • Updated deprecation notice: Basecamp 3 is no longer available for Windows as a stand-alone app (effective 2025-12-17).
    • Clarified that Basecamp 3 and 4 have transitioned to a portable web app model.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Walkthrough

A new top-level key named ## was added to deprecated/basecamp.json, containing an array of two deprecation messages about Basecamp: one noting Basecamp 3 is no longer available as a stand‑alone Windows app and another stating Basecamp 3 and 4 moved to a portable web app model. No other fields or logic were changed.

Changes

Cohort / File(s) Summary
Deprecation Metadata Addition
deprecated/basecamp.json
Added new top-level ## key with an array of two deprecation messages: (1) "Deprecated 2025-12-17: Basecamp 3 is no longer available for windows as a stand-alone app." and (2) "Basecamp 3 and 4 switched to a portable web app model." No other fields modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single JSON file change
  • Simple metadata addition, no logic or behavioral changes

Poem

🐰 I scribble notes beneath the moonlight,
Two little lines to mark the flight,
Windows doors closed, the web takes flight,
A tiny carrot of truth tonight. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: deprecating the Basecamp manifest.
Description check ✅ Passed The description includes issue reference, relevant context with sources, and completed checklist items per the template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7d3412 and cd6fe54.

📒 Files selected for processing (1)
  • deprecated/basecamp.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7e7295f and e7d3412.

📒 Files selected for processing (1)
  • deprecated/basecamp.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: PowerShell
  • GitHub Check: WindowsPowerShell

Comment on lines 2 to 5
"##": [
"Deprecated 2025-12-17: Basecamp 2 is no longer available for windows.",
"Basecamp 3 and 4 switched to a portable web app model"
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Deprecation message incorrectly identifies the manifest version.

The deprecation message states "Basecamp 2 is no longer available" but this manifest is clearly for Basecamp 3, not Basecamp 2. Evidence:

  • URLs reference basecamp3-2.4.3-full.nupkg (line 15)
  • Executable name is Basecamp 3.exe (line 22)
  • All checkver and autoupdate patterns match basecamp3 (lines 28, 34)

The version 2.4.3 is the version number of Basecamp 3, not Basecamp 2.

Apply this diff to correct the deprecation message:

     "##": [
-        "Deprecated 2025-12-17: Basecamp 2 is no longer available for windows.",
+        "Deprecated 2025-12-17: Basecamp 3 is no longer available for Windows.",
         "Basecamp 3 and 4 switched to a portable web app model"
     ],

Note: This also capitalizes "Windows" for consistency.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"##": [
"Deprecated 2025-12-17: Basecamp 2 is no longer available for windows.",
"Basecamp 3 and 4 switched to a portable web app model"
],
"##": [
"Deprecated 2025-12-17: Basecamp 3 is no longer available for Windows.",
"Basecamp 3 and 4 switched to a portable web app model"
],
🤖 Prompt for AI Agents
In deprecated/basecamp.json around lines 2 to 5, the deprecation message
incorrectly refers to "Basecamp 2" and uses lowercase "windows"; update the
deprecation text to reference "Basecamp 3" (e.g., "Deprecated 2025-12-17:
Basecamp 3 is no longer available for Windows.") and ensure "Windows" is
capitalized for consistency with other manifests.

@haussmann haussmann marked this pull request as draft December 20, 2025 23:02
@haussmann haussmann marked this pull request as ready for review December 22, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant