-
Notifications
You must be signed in to change notification settings - Fork 1.6k
basecamp: Deprecate manifest #16808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
basecamp: Deprecate manifest #16808
Conversation
WalkthroughA new top-level key named Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
deprecated/basecamp.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: PowerShell
- GitHub Check: WindowsPowerShell
| "##": [ | ||
| "Deprecated 2025-12-17: Basecamp 2 is no longer available for windows.", | ||
| "Basecamp 3 and 4 switched to a portable web app model" | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: Deprecation message incorrectly identifies the manifest version.
The deprecation message states "Basecamp 2 is no longer available" but this manifest is clearly for Basecamp 3, not Basecamp 2. Evidence:
- URLs reference
basecamp3-2.4.3-full.nupkg(line 15) - Executable name is
Basecamp 3.exe(line 22) - All checkver and autoupdate patterns match
basecamp3(lines 28, 34)
The version 2.4.3 is the version number of Basecamp 3, not Basecamp 2.
Apply this diff to correct the deprecation message:
"##": [
- "Deprecated 2025-12-17: Basecamp 2 is no longer available for windows.",
+ "Deprecated 2025-12-17: Basecamp 3 is no longer available for Windows.",
"Basecamp 3 and 4 switched to a portable web app model"
],Note: This also capitalizes "Windows" for consistency.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "##": [ | |
| "Deprecated 2025-12-17: Basecamp 2 is no longer available for windows.", | |
| "Basecamp 3 and 4 switched to a portable web app model" | |
| ], | |
| "##": [ | |
| "Deprecated 2025-12-17: Basecamp 3 is no longer available for Windows.", | |
| "Basecamp 3 and 4 switched to a portable web app model" | |
| ], |
🤖 Prompt for AI Agents
In deprecated/basecamp.json around lines 2 to 5, the deprecation message
incorrectly refers to "Basecamp 2" and uses lowercase "windows"; update the
deprecation text to reference "Basecamp 3" (e.g., "Deprecated 2025-12-17:
Basecamp 3 is no longer available for Windows.") and ensure "Windows" is
capitalized for consistency with other manifests.
Recommendation to deprecate Basecamp 2, because:
Relates to #16379
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.