Skip to content

Conversation

@SunsetMkt
Copy link
Contributor

@SunsetMkt SunsetMkt commented Nov 7, 2025

Relates to #14582

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • New Features
    • Added multi-architecture installation support for EasyTier GUI, including 64-bit and ARM64 builds.

@coderabbitai
Copy link

coderabbitai bot commented Nov 7, 2025

Walkthrough

A new JSON manifest file for EasyTier GUI is introduced, specifying multi-architecture installation configuration including 64bit and arm64 downloads, SHA-256 hashes, binary paths, version control via GitHub, and architecture-specific autoupdate URLs.

Changes

Cohort / File(s) Summary
New EasyTier GUI Manifest
bucket/easytier-gui.json
Adds manifest configuration for EasyTier GUI with multi-architecture support (64bit, arm64), download URLs, SHA-256 hashes, executable binary specification, shortcut alias, GitHub checkver source, and autoupdate block with version interpolation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify SHA-256 hashes are valid and correspond to intended release artifacts
  • Confirm download URLs point to correct GitHub release binaries for both architectures
  • Validate JSON syntax and required manifest fields

Suggested labels

review-needed

Poem

🐰 A manifest hops into the bucket today,
EasyTier GUI bundled in JSON's neat way,
Multi-arch support, from 64 to ARM,
URLs and checksums, all safely kept warm,
Autoupdate ready—no need to delay!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'easytier-gui: Add version 2.4.5' clearly and concisely summarizes the main change: adding a new version manifest for the EasyTier GUI package.
Description check ✅ Passed The pull request description includes the required conventional PR title format checkbox (checked), references a related issue (#14582), and confirms reading the contributing guide as per template requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SunsetMkt
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

All changes look good.

Wait for review from human collaborators.

easytier-gui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

All changes look good.

Wait for review from human collaborators.

easytier-gui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34d4a45 and 45074bc.

📒 Files selected for processing (1)
  • bucket/easytier-gui.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16349
File: bucket/fvim.json:45-49
Timestamp: 2025-10-16T15:59:21.258Z
Learning: In Scoop manifests, the `autoupdate.url` and `autoupdate.architecture.<arch>.url` fields must be valid URIs according to the JSON schema (defined with `"format": "uri"`). Variables like `$matchUrlx64` that contain only path segments must be combined with a base URL (e.g., `https://github.com/.../releases/download/`) to form a complete valid URI.
📚 Learning: 2025-10-19T13:58:23.389Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Extras PR: 16378
File: bucket/compactgui.json:20-22
Timestamp: 2025-10-19T13:58:23.389Z
Learning: In the ScoopInstaller/Extras repository, the CompactGUI manifest removed hash verification from the autoupdate block because the hash verification mechanism (scraping SHA-256 from release page HTML) is no longer available in newer CompactGUI releases. GitHub asset digests exist in beta releases but not in v3.8.0, and Scoop doesn't have built-in support for extracting from GitHub API asset digests.

Applied to files:

  • bucket/easytier-gui.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

"hash": "52bdd7b52ba11036636673e28b71e14637fd915b3a4189eea20f81d833ac77bf"
}
},
"bin": "easytier-gui.exe",
Copy link
Member

@z-Fng z-Fng Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add 32-bit version as well.

  2. https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md

    If the program file is a GUI application and it doesn't accept any commandline arguments, no need to add it in bin.

    Does it accept any command-line arguments?

  3. Should we consider support both CLI and GUI in EasyTier instead? Something like: b3249bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants