Skip to content

Remove unittest reliance on optional dependencies#6976

Merged
trexfeathers merged 25 commits intoSciTools:mainfrom
ESadek-MO:core_deps
Apr 16, 2026
Merged

Remove unittest reliance on optional dependencies#6976
trexfeathers merged 25 commits intoSciTools:mainfrom
ESadek-MO:core_deps

Conversation

@ESadek-MO
Copy link
Copy Markdown
Contributor

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@ESadek-MO ESadek-MO requested a review from pp-mo March 11, 2026 21:36
@ESadek-MO
Copy link
Copy Markdown
Contributor Author

This can be reviewed, all changes are for this, but I messed up branch management so will either need a rebase or a copy over

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.12%. Comparing base (043b0bc) to head (95d6960).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6976      +/-   ##
==========================================
+ Coverage   90.11%   90.12%   +0.01%     
==========================================
  Files          91       91              
  Lines       24912    24951      +39     
  Branches     4675     4683       +8     
==========================================
+ Hits        22449    22488      +39     
  Misses       1684     1684              
  Partials      779      779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ESadek-MO ESadek-MO marked this pull request as ready for review March 12, 2026 16:01
Copy link
Copy Markdown
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's been a bit of confusion with files that should have moved from unit to integration,
but the old place didn't get deleted.

Otherwise, looking pretty good !

Comment thread lib/iris/tests/integration/experimental/stratify/test_relevel.py Outdated
Comment thread lib/iris/tests/unit/pandas/test_pandas.py Outdated
Comment thread lib/iris/tests/unit/pandas/test_pandas.py Outdated
Comment thread lib/iris/tests/integration/util/test_mask_cube_from_shapefile.py Outdated
pp-mo
pp-mo previously requested changes Mar 13, 2026
Copy link
Copy Markdown
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More.
Not sure why it wouldn't let me add this one to the existing review, I'm sure it let me do that with the previous one ??

Comment thread lib/iris/tests/integration/util/test_mask_cube_from_shapefile.py
@pp-mo pp-mo linked an issue Mar 16, 2026 that may be closed by this pull request
5 tasks
Copy link
Copy Markdown
Contributor Author

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a whatsnew!

Copy link
Copy Markdown
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ESadek-MO, I'm satisfied that you have addressed all of @pp-mo's comments, and I've done a cursory check to make sure I personally understand what's going on. LGTM 👍

@trexfeathers trexfeathers merged commit df34e07 into SciTools:main Apr 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Only use core dependencies for unit tests

3 participants