Remove unittest reliance on optional dependencies#6976
Remove unittest reliance on optional dependencies#6976trexfeathers merged 25 commits intoSciTools:mainfrom
Conversation
|
This can be reviewed, all changes are for this, but I messed up branch management so will either need a rebase or a copy over |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6976 +/- ##
==========================================
+ Coverage 90.11% 90.12% +0.01%
==========================================
Files 91 91
Lines 24912 24951 +39
Branches 4675 4683 +8
==========================================
+ Hits 22449 22488 +39
Misses 1684 1684
Partials 779 779 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pp-mo
left a comment
There was a problem hiding this comment.
There's been a bit of confusion with files that should have moved from unit to integration,
but the old place didn't get deleted.
Otherwise, looking pretty good !
pp-mo
left a comment
There was a problem hiding this comment.
More.
Not sure why it wouldn't let me add this one to the existing review, I'm sure it let me do that with the previous one ??
ESadek-MO
left a comment
There was a problem hiding this comment.
Also needs a whatsnew!
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @ESadek-MO, I'm satisfied that you have addressed all of @pp-mo's comments, and I've done a cursory check to make sure I personally understand what's going on. LGTM 👍
🚀 Pull Request
Description
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: