Skip to content

remove footer for embbeding page #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iceljc merged 1 commit into from
Mar 31, 2026
+7 −3
Merged

remove footer for embbeding page #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/scss/custom/pages/_agent.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,7 @@

.embedding-container {
padding: 0px;
height: calc(100vh - #{$header-height} - #{$grid-gutter-width} - #{$footer-height});
height: calc(100vh - #{$header-height} - #{$grid-gutter-width} - 0.2 * #{$footer-height});
Copy link
Copy Markdown

@qodo-code-review qodo-code-review bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Embed height ignores footer 🐞 Bug ≡ Correctness

.embedding-container now subtracts only 0.2 * $footer-height, but /page routes still render
the absolute-positioned 60px footer, so embedding pages that keep the footer (e.g. Knowledge Base
embed) will have embedded content covered by the footer. This can hide/cut off the bottom of the
embedded iframe/component and block interaction with its UI.
Agent Prompt 
## Issue description
The global `.embedding-container` height change makes the embedded content area extend into the footer region on embedding routes that still render the footer.

## Issue Context
`EmbeddingPage` is reused by multiple embedding routes, but only the *agent* embed route hides the footer via a page-local `<svelte:head>` override. Other embedding routes (e.g. Knowledge Base embed) still render the footer.

## Fix Focus Areas
- src/lib/scss/custom/pages/_agent.scss[435-442]
- src/routes/VerticalLayout/Index.svelte[48-67]
- src/routes/page/knowledge-base/[embed]/[embedType]/+page.svelte[1-20]

## Suggested fix approach
1) Pick one consistent behavior for *all* embedding routes:
   - **Option A (recommended):** Conditionally *do not render* `<Footer />` when `isEmbeddingPage` (based on `$page.params.embed` and `$page.params.embedType`), then set `.embedding-container` height to not subtract footer height.
   - **Option B:** Keep rendering the footer on non-agent embed pages; revert `.embedding-container` height to subtract the full `$footer-height` and only override the height on routes where the footer is actually removed.
2) Ensure the final embed container height does not result in any footer overlap on routes where the footer remains visible.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

width: calc(100% + #{$grid-gutter-width} * 2);
margin-left: calc(-1 * (#{$grid-gutter-width} * 0.75 + #{$grid-gutter-width} * 0.5));
margin-right: calc(-1 * (#{$grid-gutter-width} * 0.75 + #{$grid-gutter-width} * 0.5));
Expand Down
8 changes: 6 additions & 2 deletions src/routes/page/agent/[embed]/[embedType]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@
import { page } from '$app/stores';
import lodash from 'lodash';
import HeadTitle from "$lib/common/shared/HeadTitle.svelte";
import Breadcrumb from '$lib/common/shared/Breadcrumb.svelte';
import EmbeddingPage from '$lib/common/embedding/EmbeddingPage.svelte';

/** @type {string?} */
let label = '';
</script>

<svelte:head>
<style>
.footer { display: none !important; }
</style>
</svelte:head>

<HeadTitle title="{$_(label || 'Agent')}" addOn={`${lodash.capitalize($page.params.embed || '')}`} />
<Breadcrumb title="{$_('Agent')}" pagetitle="{$_(label || 'Agent')}" />

<EmbeddingPage
htmlTagId="agent-embed-content"
Expand Down
Loading