Add support for definite integration #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ai-maintainer[bot]](https://avatars.githubusercontent.com/in/339956?s=60&v=4){kind=small}
There was a problem hiding this comment.
AI-Maintainer Review for PR - Add support for definite integration
Title and Description 👍
Details
The title of the pull request is clear and concise. It effectively communicates the purpose of the changes, which is to add support for definite integration. The description could benefit from a more detailed explanation of the changes being made and the motivation behind them.Scope of Changes 👍
Details
The changes are narrowly focused on adding support for definite integration. The diff only includes modifications to the `integral.jl` file, specifically within the `integrate` function. There are no indications that the author is trying to resolve multiple issues simultaneously.Documentation 👎
Details
The `integrate` function requires a docstring to describe its behavior, arguments, and return values. Please add a docstring to this function.Testing 👎
Details
The description of the pull request does not mention how the author tested the changes. It would be beneficial for the author to provide information on how they tested the changes to ensure their correctness and functionality.Suggested Changes
- Please add a docstring to the
integratefunction to describe its behavior, arguments, and return values. This will help other developers understand the purpose and usage of this function. - Please provide information on how you tested the changes. This could include unit tests, integration tests, or manual testing procedures. This will help ensure the changes are functioning as expected and have not introduced any new issues.
Reviewed with AI Maintainer
Member
It would be good to test a few values and cases. |
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
- Coverage 64.96% 0.10% -64.87%
==========================================
Files 14 14
Lines 942 933 -9
==========================================
- Hits 612 1 -611
- Misses 330 932 +602
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| - `err`: the numerical error in reaching the solution | ||
| """ | ||
| function integrate(eq, x = nothing, domain::Vector{<:Number} = nothing; abstol = 1e-6, num_steps = 2, num_trials = 10, | ||
| function integrate(eq, x = nothing, domain::Vector{<:Number} = [NaN]; abstol = 1e-6, num_steps = 2, num_trials = 10, |
Member
There was a problem hiding this comment.
for safety make it nothing by default.
|
I think this can be closed as superseded by #63 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this Discourse conversation: https://discourse.julialang.org/t/integrating-symbolic-functions/102545
Thought I'd start a basic MR with the most naive implementation, and let it evolve from here. I've only done the most basic manual testing (e.g. integrate$x$ over the domain [0,1]), but am open to suggestions for how to build out testing -- is it enough to rely on
Symbolics.substituteunit tests, and then just a few return-type / edge case tests?