clamp lower bound of mipmap width/height#55
Open
buhman wants to merge 1 commit intoSaschaWillems:mainfrom
Open
clamp lower bound of mipmap width/height#55buhman wants to merge 1 commit intoSaschaWillems:mainfrom
buhman wants to merge 1 commit intoSaschaWillems:mainfrom
Conversation
Prior to this commit, width/height values could be right-shifted to zero (when loading non-square textures).
Owner
|
The tutorial does only use power-of-two textures. Not sure why this is required here. |
Contributor
Author
|
It does not increase the complexity of the tutorial code significantly, and it also means that if someone wants to re-use the tutorial code with a different (non-square or non-power-of-two) texture, that the calculated mip level dimensions remain correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, width/height values could be right-shifted to zero (when loading non-square textures).