Refactor chk to macro with source location#20
Open
GHF wants to merge 1 commit intoSaschaWillems:mainfrom
Open
Conversation
Prints out source text and location when a chk fails. Also fixes minor bug of exiting with 0 with chk(false).
There was a problem hiding this comment.
Pull request overview
This PR refactors the chk error checking function into a macro that captures source location information for better debugging, and fixes a bug where chk(false) would exit with code 0 instead of a failure code.
Changes:
- Converted
chkfunction to a macro that captures source location, file, and line information - Added detailed error messages showing where checks fail and what expression was evaluated
- Fixed bug where boolean check failures would exit with code 0 instead of -1
- Removed unused
<fstream>include and added<source_location>include
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you might consider this too C++-y but while hacking on the tutorial for macOS, I ran into a lot of different call failures and this really helped track them down.
Prints out source text and location when a chk fails.
Also fixes minor bug of exiting with 0 with chk(false).