Skip to content

# 3839 Fixed handling of None for logic.kernel_module#3845

Merged
krzywon merged 1 commit intomainfrom
3839-batch-fitting-throws-error-post-refactor-3
Feb 2, 2026
Merged

# 3839 Fixed handling of None for logic.kernel_module#3845
krzywon merged 1 commit intomainfrom
3839-batch-fitting-throws-error-post-refactor-3

Conversation

@rozyczko
Copy link
Copy Markdown
Member

Description

Batch fitting is throwing a (harmless) error. This doesn't look nice.
The bug occurred because self.logic.kernel_module can be None during batch fitting, which caused an AttributeError when updateKernelWithResults tried to call setParam() on it.

Fixes #3839

How Has This Been Tested?

Local Win10 build

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@rozyczko rozyczko requested a review from krzywon January 24, 2026 10:52
Copy link
Copy Markdown
Contributor

@krzywon krzywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue and code looks fine.

@krzywon krzywon merged commit 3d35bda into main Feb 2, 2026
48 checks passed
@krzywon krzywon deleted the 3839-batch-fitting-throws-error-post-refactor-3 branch February 2, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch Fitting throws error (post refactor #3)

2 participants