Conversation
Also added more comments, and removed a TODO that needed to be moved to a github question.
| { "5D8D9DE8-29C8-4F01-BDBC-F2D4D7DD6E82", "732 (Hidden Manifest 0374, 5384752978584135997, Hidden Manifest 1483, Hidden Manifest 0028, Hidden Manifest 1278, Hidden Manifest 1591) - client.dll" }, | ||
| { "0A6326B2-F166-487A-A89B-E8930DD16E11", "732 (Hidden Manifest 0603, Hidden Manifest 0476) - client.dll" }, | ||
| { "7F2D929C-03C6-493A-A7D7-AE5428A7C119", "732 (Hidden Manifest 0275, Hidden Manifest 1144) - client.dll" }, | ||
| { "0483C301-20E4-47F3-B4 |
There was a problem hiding this comment.
HashSets are supported on .Net Framework 3.5 or greater, but it doesn't seem like there are any version-specific NetFramework flags? Is this proper, given the supported versions are
.NET Core 1.0, Core 1.1, Core 2.0, Core 2.1, Core 2.2, Core 3.0, Core 3.1, 5, 6, 7, 8, 9, 10, 11
.NET Framework 3.5, 4.0, 4.5, 4.5.1, 4.5.2, 4.6, 4.6.1, 4.6.2, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1
.NET Standard 1.0, 1.1, 1.2, 1.3, 1.4, 1.6, 2.0, 2.1
There was a problem hiding this comment.
NET35_OR_GREATER | NETCOREAPP | NETSTANDARD2_0_OR_GREATER is likely what you're looking for. That being said, I would strongly prefer if you don't gate the entire item on this. A slightly better approach would be to do something similar to this:
#if NET20 || NET35
private static readonly List<string> HaveStrips =
#else
private static readonly HashSet<string> HaveStrips =
#endifThis still allows ancient .NET to access the data, since the value-uniqueness will be guaranteed by the other .NET versions.
…because I made a more advanced script that allows me to update the table more easily and reliably locally.
|
The changes needed in Serialization have been released. Please revisit this when you have the chance. |
| // The large dictionaries and hash sets that CEG.cs needs for its logic. | ||
| // Contained in a separate file since dictionary size is very large. |
There was a problem hiding this comment.
These comments really aren't needed
| { "5D8D9DE8-29C8-4F01-BDBC-F2D4D7DD6E82", "732 (Hidden Manifest 0374, 5384752978584135997, Hidden Manifest 1483, Hidden Manifest 0028, Hidden Manifest 1278, Hidden Manifest 1591) - client.dll" }, | ||
| { "0A6326B2-F166-487A-A89B-E8930DD16E11", "732 (Hidden Manifest 0603, Hidden Manifest 0476) - client.dll" }, | ||
| { "7F2D929C-03C6-493A-A7D7-AE5428A7C119", "732 (Hidden Manifest 0275, Hidden Manifest 1144) - client.dll" }, | ||
| { "0483C301-20E4-47F3-B4 |
There was a problem hiding this comment.
NET35_OR_GREATER | NETCOREAPP | NETSTANDARD2_0_OR_GREATER is likely what you're looking for. That being said, I would strongly prefer if you don't gate the entire item on this. A slightly better approach would be to do something similar to this:
#if NET20 || NET35
private static readonly List<string> HaveStrips =
#else
private static readonly HashSet<string> HaveStrips =
#endifThis still allows ancient .NET to access the data, since the value-uniqueness will be guaranteed by the other .NET versions.
| /// <returns>A string about reporting on GitHub if not found, otherwise returns null.</returns> | ||
| private string? ReportHelper(string steamSplitGuid) | ||
| { | ||
| #if NETSTANDARD2_0_OR_GREATER || NET21_OR_GREATER || NETCOREAPP |
There was a problem hiding this comment.
If you make the suggested gated type change from the above comment, then this #if will be unnecessary.
|
Overarching comment: Since it's hard to scan visually, please do an auto-format pass on the PR code as well. There may be some spacing and double-newline issues in there. |
2 participants
Some minor updates might come in the future with slow/eventual additions, but other than that, this should be done.