Merged
Conversation
EvgeniiChaikin
approved these changes
Apr 25, 2025
Collaborator
EvgeniiChaikin
left a comment
EvgeniiChaikin
left a comment
There was a problem hiding this comment.
Thanks @robjmcgibbon !
I have tested these changes; everything works correctly!
One small comment: could you please slightly clarify the description of upper and lower in velociraptor/autoplotter/__init__.py? Something like: The y-values of the mean/median line will be clipped from below at lower and from above at upper
Collaborator
|
Also, ideally, it would be nice to make the pipeline crash on input if |
Collaborator
Author
|
Thanks, I've made the suggested changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The autoplotter allows for a
lowervalue to be passed. Currently this removes all datapoints with values smaller than the value oflower. This can lead to incorrect percentiles when calculating medians. This PR instead set the value ofloweras a floor value.