[Feature] Consolidate duplicated ResourceLoader into shared Reporting implementation; fixes #44#71
Merged
Merged
Conversation
… implementation; fixes #44
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



@
Factors the duplicated embedded-resource loading logic out of
ECoreNetto.ToolsandECoreNetto.Reportinginto a single shared implementation.Changes
ECoreNetto.Reporting/Resources/ResourceLoader.cs— now the single source of truth. Madepublicand changed the signature toLoadEmbeddedResource(Assembly assembly, string path). TheAssemblyis passed in explicitly so callers in other assemblies resolve resources from their own manifest (the reason the logic could not simply be shared as-is:Assembly.GetExecutingAssembly()would always return the Reporting assembly).ECoreNetto.Reporting/Generators/HandleBarsReportGenerator.cs— the single caller now passestypeof(HandleBarsReportGenerator).Assembly, where the.hbstemplates are embedded.ECoreNetto.Tools/Resources/ResourceLoader.cs— removed the duplicated loading logic;LoadEmbeddedResource(string)now delegates to the shared loader, binding the Tools assembly. The Tools-specificQueryVersion/QueryLogohelpers stay put.Acceptance criteria
ECoreNetto.Reporting; project-specific helpers kept separate.Verification
Solution builds clean (0 warnings/0 errors); the 4
ResourceLoaderTestFixturetests and all 23 Reporting tests pass. Public Tools API (LoadEmbeddedResource(string),QueryVersion,QueryLogo) is preserved, so no test changes were needed.Closes #44
@