Skip to content

[autobackport: sssd-2-12] adding sss_ssh_knownhosts test case#8493

Merged
danlavu merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8448-to-sssd-2-12
Mar 18, 2026
Merged

[autobackport: sssd-2-12] adding sss_ssh_knownhosts test case#8493
danlavu merged 1 commit intoSSSD:sssd-2-12from
sssd-bot:SSSD-sssd-backport-pr8448-to-sssd-2-12

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

@sssd-bot sssd-bot commented Mar 4, 2026

This is an automatic backport of PR#8448 adding sss_ssh_knownhosts test case to branch sssd-2-12, created by @danlavu.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8448-to-sssd-2-12
git checkout SSSD-sssd-backport-pr8448-to-sssd-2-12
git push sssd-bot SSSD-sssd-backport-pr8448-to-sssd-2-12 --force

Original commits
b4e88e8 - adding sss_ssh_knownhosts test case

Backported commits

  • 618ff6a - adding sss_ssh_knownhosts test case

Original Pull Request Body

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a system test for sss_ssh_knownhosts. The new test contains a syntax error that will prevent it from running. Additionally, it introduces dependencies on external network services, which can cause test flakiness. I've provided a suggestion to fix the syntax and remove the external dependencies to improve test reliability.

Comment thread src/tests/system/tests/test_tools.py
Reviewed-by: Anuj Borah <aborah@redhat.com>
Reviewed-by: Alejandro López <allopez@redhat.com>
(cherry picked from commit b4e88e8)
@sssd-bot
Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @danlavu with the following PR CI status:


🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8448-to-sssd-2-12 branch from 618ff6a to 2a23b93 Compare March 18, 2026 03:52
@danlavu
Copy link
Copy Markdown

danlavu commented Mar 18, 2026

@aborah-sudo ping

@danlavu danlavu merged commit 7ade1ba into SSSD:sssd-2-12 Mar 18, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants