Skip to content

[autobackport: sssd-2-11] tests: reorganize infopipe tests by interface#8462

Merged
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-11from
sssd-bot:SSSD-sssd-backport-pr8451-to-sssd-2-11
Apr 24, 2026
Merged

[autobackport: sssd-2-11] tests: reorganize infopipe tests by interface#8462
alexey-tikhonov merged 1 commit intoSSSD:sssd-2-11from
sssd-bot:SSSD-sssd-backport-pr8451-to-sssd-2-11

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

This is an automatic backport of PR#8451 tests: reorganize infopipe tests by interface to branch sssd-2-11, created by @aborah-sudo.

Please make sure this backport is correct.

Note

The commits were cherry-picked without conflicts.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8451-to-sssd-2-11
git checkout SSSD-sssd-backport-pr8451-to-sssd-2-11
git push sssd-bot SSSD-sssd-backport-pr8451-to-sssd-2-11 --force

Original commits
1571946 - tests: reorganize infopipe tests by interface

Backported commits

  • e15bcef - tests: reorganize infopipe tests by interface

Original Pull Request Body

Group the infopipe tests into logical sections based on the D-Bus interface they exercise:

  • Infopipe (root object)
  • Domains
  • Users
  • Groups
  • Mixed/Combined interfaces

This is a pure reorganization with no logic changes to improve test maintainability and readability.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the infopipe tests into logical sections based on the D-Bus interface they exercise. This is a pure refactoring with no logic changes, which significantly improves the test suite's maintainability and readability. The new structure is clear and well-organized. I've reviewed the changes and found no issues. The reorganization is well-executed and a good improvement for the codebase.

@alexey-tikhonov alexey-tikhonov added no-backport This should go to target branch only. Accepted labels Apr 24, 2026
Group the infopipe tests into logical sections based on the D-Bus
interface they exercise:
- Infopipe (root object)
- Domains
- Users
- Groups
- Mixed/Combined interfaces

This is a pure reorganization with no logic changes to improve test
maintainability and readability.

Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Shridhar Gadekar <sgadekar@redhat.com>
(cherry picked from commit 1571946)
@sssd-bot
Copy link
Copy Markdown
Contributor Author

The pull request was accepted by @alexey-tikhonov with the following PR CI status:


🟢 CodeQL (success)
🟢 rpm-build:centos-stream-10-x86_64:upstream (success)
🟢 rpm-build:fedora-42-x86_64:upstream (success)
🟢 rpm-build:fedora-43-x86_64:upstream (success)
🟢 rpm-build:fedora-44-x86_64:upstream (success)
🟢 rpm-build:fedora-rawhide-x86_64:upstream (success)
➖ ci / intgcheck (skipped)
🔴 ci / prepare (failure)
➖ ci / system (skipped)
🟢 Static code analysis / codeql (success)
🟢 Static code analysis / pre-commit (success)
🟢 Static code analysis / python-system-tests (success)


There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging.

@sssd-bot sssd-bot force-pushed the SSSD-sssd-backport-pr8451-to-sssd-2-11 branch from e15bcef to 04246dc Compare April 24, 2026 17:26
@alexey-tikhonov alexey-tikhonov merged commit 1ed2fe5 into SSSD:sssd-2-11 Apr 24, 2026
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Accepted no-backport This should go to target branch only. Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants