[autobackport: sssd-2-12] SBUS: increase SBUS_MESSAGE_TIMEOUT to 5 mins#8383
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request backports two changes: an increase of the SBUS message timeout and a fix for the client idle timer. The increase of SBUS_MESSAGE_TIMEOUT to 5 minutes in src/sbus/sbus_message.h is a reasonable adjustment to prevent timeouts on potentially long-running operations, such as initgroups for users with a vast number of group memberships, as noted in the code comment. The fixes in src/responder/common/responder_common.c correct a potential bug in the client idle connection reaping logic. The change of the comparison operator to >= and the adjustment of the timer's offset ensure that idle connections are terminated in a more accurate and timely manner, especially addressing edge cases related to timeout values. Both changes are sound and improve the reliability of SSSD.
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
backport looks like the original, ACK.
bye,
Sumit
Handling BE_REQ_INITGROUPS for LDAP user with 10k groups takes longer than 2 mins. Reviewed-by: Pavel Březina <pbrezina@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit ee081e1)
As it was implemented previously, effective period was 1.5*client_idle_timeout instead of `client_idle_timeout` as documented. Log with default value - 60 - before a fix: ``` (:49:12): [nss] [setup_client_idle_timer] (0x4000): Idle timer re-set for client [0x557af16f31b0][22] (:49:42): [nss] [setup_client_idle_timer] (0x4000): Idle timer re-set for client [0x557af16f31b0][22] (:50:12): [nss] [setup_client_idle_timer] (0x4000): Idle timer re-set for client [0x557af16f31b0][22] (:50:42): [nss] [client_idle_handler] (0x2000): Terminating idle client [0x557af16f31b0][22] ``` Reviewed-by: Pavel Březina <pbrezina@redhat.com> Reviewed-by: Sumit Bose <sbose@redhat.com> (cherry picked from commit 7762901)
|
The pull request was accepted by @alexey-tikhonov with the following PR CI status: 🟢 rpm-build:centos-stream-10-x86_64:upstream (success) There are unsuccessful or unfinished checks. Make sure that the failures are not related to this pull request before merging. |
sssd-bot
force-pushed
the
SSSD-sssd-backport-pr8367-to-sssd-2-12
branch
from
2928a30 to
5d631af
Compare
4 participants
This is an automatic backport of PR#8367 SBUS: increase SBUS_MESSAGE_TIMEOUT to 5 mins to branch sssd-2-12, created by @alexey-tikhonov.
Please make sure this backport is correct.
Note
The commits were cherry-picked without conflicts.
You can push changes to this pull request
Original commits
ee081e1 - SBUS: increase SBUS_MESSAGE_TIMEOUT to 5 mins
7762901 - RESPONDER: fixed an issue with 'client_idle_timer'
Backported commits
Original Pull Request Body
... and fixed an issue with 'client_idle_timer'