Translations update from Fedora Weblate - origin/sssd-2-7 #8374
Translations update from Fedora Weblate - origin/sssd-2-7 #8374weblate wants to merge 1 commit intoSSSD:sssd-2-7from
Conversation
Updated by "Update LINGUAS file" hook in Weblate. Translation: SSSD/SSSD-2-7 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-2-7/ Added translation using Weblate (Latvian) Added translation using Weblate (Georgian) Added translation using Weblate (Breton)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds translation files for Breton (br), Georgian (ka), and Latvian (lv). The changes appear to be automatically generated by Weblate. While the files for Breton and Latvian seem correct, I've found a significant issue in the Georgian translation file (po/ka.po) regarding the plural forms configuration. This could lead to build failures or incorrect pluralization at runtime. I have provided specific comments and suggestions to rectify this.
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: 8bit\n" | ||
| "Plural-Forms: nplurals=2; plural=n != 1;\n" |
There was a problem hiding this comment.
The plural form for Georgian (ka) appears to be incorrect. According to multiple sources, including the GNU gettext manual and common practice in projects like GNOME, Georgian is treated as a language with a single plural form. The correct Plural-Forms header should be nplurals=1; plural=0;. Using the current value could lead to incorrect grammar or build failures when processing the file.
"Plural-Forms: nplurals=1; plural=0;\n"
| #: src/sss_client/pam_sss.c:609 | ||
| #, c-format |
There was a problem hiding this comment.
In conjunction with correcting the Plural-Forms header for Georgian to nplurals=1, this plural message should only have one msgstr entry (msgstr[0]). The presence of msgstr[1] will cause a syntax error when nplurals=1 is set in the header.
msgstr[0] ""
| msgstr "" | ||
|
|
There was a problem hiding this comment.
In conjunction with correcting the Plural-Forms header for Georgian to nplurals=1, this plural message should only have one msgstr entry (msgstr[0]). The presence of msgstr[1] will cause a syntax error when nplurals=1 is set in the header.
msgstr[0] ""
2 participants
Translations update from Fedora Weblate for SSSD/SSSD-2-7.
Current translation status: