SPEC: since Fedora 44 Samba provides dedicated 'samba-ndr-libs' package#8372
Merged
alexey-tikhonov merged 1 commit intoSSSD:masterfrom Jan 19, 2026
Merged
SPEC: since Fedora 44 Samba provides dedicated 'samba-ndr-libs' package#8372alexey-tikhonov merged 1 commit intoSSSD:masterfrom
alexey-tikhonov merged 1 commit intoSSSD:masterfrom
Conversation
alexey-tikhonov
added
no-backport
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the RPM spec file to handle a dependency change in Fedora 44 and later. The sssd-ipa package now correctly requires samba-ndr-libs on Fedora 44+ and falls back to samba-client-libs on older versions or other distributions. The implementation uses a standard conditional macro, and the change is correctly scoped to the ipa subpackage, leaving the sssd-ad dependency untouched as intended. The change is correct and well-implemented.
sumit-bose
approved these changes
Jan 19, 2026
Contributor
sumit-bose
left a comment
sumit-bose
left a comment
There was a problem hiding this comment.
Hi,
thank you, works as expected, samba-client-libs is not loaded when runnig dnf install sssd-ipa, ACK.
bye,
Sumit
with libraries needed by 'sssd-ipa'. Note that 'sssd-ad' still needs 'samba-client-libs' Reviewed-by: Sumit Bose <sbose@redhat.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with libraries needed by 'sssd-ipa'.
Note that 'sssd-ad' still needs 'samba-client-libs'