chore: update version to 0.9.2 and enhance SmtpMockServer with receiv…#11
Merged
Conversation
…ed email tracking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the project version to 0.9.2 and extends the testkit SMTP mock server utilities to make it easier for tests to inspect emails received by the in-process SMTP server.
Changes:
- Bump build version from 0.9.1 → 0.9.2.
- Add
received: Seq[SmtpMessage]toSmtpMockServerfor received-email tracking. - Broaden visibility of the SMTP mock server handle in
NotificationTestKitto enable access from subclasses.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| testkit/src/main/scala/app/softnetwork/notification/scalatest/SmtpMockServer.scala | Adds a received accessor returning received SMTP messages and required imports. |
| testkit/src/main/scala/app/softnetwork/notification/scalatest/NotificationTestKit.scala | Changes SMTP mock server handle visibility to allow subclass access. |
| build.sbt | Updates the project version to 0.9.2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 71.51% 71.74% +0.23%
==========================================
Files 61 61
Lines 1113 1115 +2
Branches 161 171 +10
==========================================
+ Hits 796 800 +4
+ Misses 317 315 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Changing smtpMockServer from private to a protected var exposes mutable internal state to subclasses (unlike the other mock server handles in this trait, which remain private). This makes it easier to accidentally reassign/clear the handle and break shutdown semantics. Prefer keeping the field private and exposing a minimal protected accessor for received emails (or an Option getter) instead. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed email tracking