Make sure that features can be disabled cleanly#32
Open
cyqsimon wants to merge 4 commits intoSOF3:masterfrom
Open
Make sure that features can be disabled cleanly#32cyqsimon wants to merge 4 commits intoSOF3:masterfrom
cyqsimon wants to merge 4 commits intoSOF3:masterfrom
Conversation
Contributor
Author
|
Just found some issues that could use a bit of extra fixing up. Will do an interactive rebase to tidy up the history. |
cyqsimon
force-pushed
the
feature-gate
branch
2 times, most recently
from
0e754be to
f735bbb
Compare
cyqsimon
commented
Jan 2, 2026
Comment on lines
99
to
106
|
|
||
| $(#[$meta])* | ||
| $(pub $(($($vis)+))?)? static $name: ::std::sync::LazyLock<::std::vec::Vec<u8>> = ::std::sync::LazyLock::new(|| { | ||
| $crate::decode($crate::codegen::deflate_file!($path), None) | ||
| let algo = $crate::__parse_algo!($($algo)?); | ||
| $crate::decode($crate::codegen::deflate_file!($path $($algo)?), Some(algo)) | ||
| }); | ||
| }; | ||
| ($(#[$meta:meta])* |
Contributor
Author
There was a problem hiding this comment.
This must have been an oversight in #25 no? Anyways, proper support has been added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While bumping my dependency on
include-flatefor one of my repos, I noticed that the post-bump version had issues with cross-compilation due to a newzstddependency. That's an unrelated issue withcargo-xwin, but it did lead me to notice that currently it is impossible to fully eliminatelibflateorzstdas dependencies ofinclude-flate, even if you don't actually use them.In other words, feature enablement hasn't been done cleanly. This PR fixes that, and adds the appropriate checks to guard against it in the future.