chore: update project dependencies to use type-safe accessors and bump version to 1.21.11-2.61.0#238
Merged
ammodev merged 1 commit intoversion/1.21.11from Mar 7, 2026
Merged
Conversation
…p version to 1.21.11-2.61.0
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Gradle build configuration to use type-safe project accessors, bumps the project version, and removes the (previously present) Hytale platform modules/plugin support.
Changes:
- Migrated many
project(":path")dependencies toprojects.*type-safe accessors. - Enabled
TYPESAFE_PROJECT_ACCESSORSinsettings.gradle.ktsand added a new settings plugin for it. - Removed Hytale server/api modules and the Gradle plugin code that generated/handled Hytale plugin files; bumped version to
1.21.11-2.61.0.
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| surf-api-velocity/surf-api-velocity-server/build.gradle.kts | Switches project dependencies to type-safe accessors. |
| surf-api-velocity/surf-api-velocity-api/build.gradle.kts | Switches core API dependency to type-safe accessor. |
| surf-api-standalone/build.gradle.kts | Switches core server dependency to type-safe accessor. |
| surf-api-shared/surf-api-shared-internal/build.gradle.kts | Switches shared public dependency to type-safe accessor. |
| surf-api-modern-generator/build.gradle.kts | Switches core API dependency to type-safe accessor; minor formatting change. |
| surf-api-hytale/surf-api-hytale-server/src/main/resources/manifest.json | Removes Hytale manifest template. |
| surf-api-hytale/surf-api-hytale-server/src/main/kotlin/dev/slne/surf/surfapi/hytale/server/impl/SurfHytaleApiImpl.kt | Removes Hytale server implementation. |
| surf-api-hytale/surf-api-hytale-server/src/main/kotlin/dev/slne/surf/surfapi/hytale/server/coroutines/impl/HysCoroutineImpl.kt | Removes Hytale coroutine implementation. |
| surf-api-hytale/surf-api-hytale-server/src/main/kotlin/dev/slne/surf/surfapi/hytale/server/coroutines/impl/CoroutineSessionImpl.kt | Removes Hytale coroutine session implementation. |
| surf-api-hytale/surf-api-hytale-server/src/main/kotlin/dev/slne/surf/surfapi/hytale/server/coroutines/dispatcher/PluginDispatcher.kt | Removes Hytale coroutine dispatcher. |
| surf-api-hytale/surf-api-hytale-server/src/main/kotlin/dev/slne/surf/surfapi/hytale/server/coroutines/dispatcher/MainDispatcher.kt | Removes Hytale main dispatcher. |
| surf-api-hytale/surf-api-hytale-server/src/main/kotlin/dev/slne/surf/surfapi/hytale/server/HytaleMain.kt | Removes Hytale plugin entrypoint. |
| surf-api-hytale/surf-api-hytale-server/src/main/kotlin/dev/slne/surf/surfapi/hytale/server/HytaleInstance.kt | Removes Hytale CoreInstance integration. |
| surf-api-hytale/surf-api-hytale-server/build.gradle.kts | Removes Hytale server Gradle module configuration. |
| surf-api-hytale/surf-api-hytale-api/src/main/kotlin/dev/slne/surf/surfapi/hytale/api/coroutines/SuspendingJavaPlugin.kt | Removes Hytale coroutine API support type. |
| surf-api-hytale/surf-api-hytale-api/src/main/kotlin/dev/slne/surf/surfapi/hytale/api/coroutines/HysCoroutineExceptionEvent.kt | Removes Hytale coroutine exception event type. |
| surf-api-hytale/surf-api-hytale-api/src/main/kotlin/dev/slne/surf/surfapi/hytale/api/coroutines/HysCoroutine.kt | Removes Hytale coroutine API entrypoints/extensions. |
| surf-api-hytale/surf-api-hytale-api/src/main/kotlin/dev/slne/surf/surfapi/hytale/api/coroutines/CoroutineSession.kt | Removes Hytale coroutine session API. |
| surf-api-hytale/surf-api-hytale-api/src/main/kotlin/dev/slne/surf/surfapi/hytale/api/SurfHytaleApi.kt | Removes Hytale API surface. |
| surf-api-hytale/surf-api-hytale-api/build.gradle.kts | Removes Hytale API Gradle module configuration. |
| surf-api-hytale/surf-api-hytale-api/api/surf-api-hytale-api.api | Removes API validation dump for Hytale API. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/surfapi/gradle/settings/SurfSettingsPlugin.kt | Adds a settings plugin that enables type-safe project accessors. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/surfapi/gradle/platform/hytale/HytaleSurfPlugin.kt | Removes Hytale Gradle plugin implementation. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/surfapi/gradle/platform/hytale/HytaleSurfExtension.kt | Removes Hytale Gradle extension. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/surfapi/gradle/generators/pluginfiles/dto/HytalePluginFileDto.kt | Removes Hytale plugin-file DTO serialization. |
| surf-api-gradle-plugin/src/main/kotlin/dev/slne/surf/surfapi/gradle/generators/pluginfiles/HytalePluginFile.kt | Removes Hytale plugin-file model/validation. |
| surf-api-gradle-plugin/build.gradle.kts | Registers new settings plugin; removes Hytale plugin registration/constants. |
| surf-api-core/surf-api-core-server/build.gradle.kts | Switches internal/core API dependencies to type-safe accessors. |
| surf-api-core/surf-api-core-api/build.gradle.kts | Switches shared public dependency to type-safe accessor. |
| surf-api-bukkit/surf-api-bukkit-server/build.gradle.kts | Switches bukkit API/core server dependencies to type-safe accessors. |
| surf-api-bukkit/surf-api-bukkit-plugin-test/build.gradle.kts | Switches bukkit API dependency to type-safe accessor. |
| surf-api-bukkit/surf-api-bukkit-api/build.gradle.kts | Switches core API dependency to type-safe accessor. |
| settings.gradle.kts | Enables type-safe project accessors; reorganizes includes; updates CI detection placement. |
| gradle.properties | Bumps project version to 1.21.11-2.61.0. |
Comment on lines
+6
to
+10
| internal class SurfSettingsPlugin : Plugin<Settings> { | ||
| override fun apply(target: Settings) { | ||
| target.enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS") | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Publishing a Gradle plugin with an internal implementation class is risky because plugin implementation classes are expected to be publicly consumable/stable. Make SurfSettingsPlugin a public class (remove internal) so Gradle can instantiate it reliably across builds and so the plugin API remains consistent.
| } | ||
|
|
||
| val ci = System.getenv("CI")?.toBoolean() == true | ||
| enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS") |
There was a problem hiding this comment.
This PR introduces a dedicated settings plugin (dev.slne.surf.surfapi.gradle.settings) that enables TYPESAFE_PROJECT_ACCESSORS, but the root settings.gradle.kts still enables the feature preview directly. To avoid having two competing ways to configure the same toggle, either (a) apply the settings plugin here and remove the direct call, or (b) remove the settings plugin entirely if it isn’t intended to be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.