feat: add 6 validators (batch 5/5) - exec_input, exec_memory_thp, exec_cpu_affinity, syscall_archs, colon_separated_paths, user_group_strv_compat#453
Conversation
…ty, syscall_archs, colon_separated_paths, user_group_strv_compat (Resolves #452) Batch 5/5 — final batch of the burn-down extension. Each grammar mirrors the systemd C parser: - config_parse_exec_input: fd:NAME | file:/PATH | enum from exec_input_table - config_parse_exec_memory_thp: inherit/disable/madvise/system enum - config_parse_exec_cpu_affinity: "numa" OR CPU set list (integers and N-M ranges, whitespace or comma separated) - config_parse_syscall_archs: list of arch names from seccomp_arch_from_string (~22 entries, includes loongarch64/riscv64 unconditionally) - config_parse_colon_separated_paths: colon-separated absolute paths (specifier-aware) - config_parse_user_group_strv_compat: relaxed user/group names, no colon/slash/whitespace, not "."/"..", specifier-aware OptionValueTest missing-function count drops 376 -> 370; found-key count rises 1870 -> 1900. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final batch (5 of 5). Each grammar derived from systemd C source:
config_parse_exec_input(0)load-fragment.c:1124fd:NAMEORfile:/PATHOR enum (null/tty/tty-force/tty-fail/socket/data)config_parse_exec_memory_thp(0)load-fragment.c:170(DEFINE_CONFIG_PARSE_ENUM)config_parse_exec_cpu_affinity(0)load-fragment.c:1822"numa"OR CPU set list (N/N-M, whitespace or comma separated)config_parse_syscall_archs(0)load-fragment.c:3377→seccomp_arch_from_stringconfig_parse_colon_separated_paths(0)load-fragment.c:448config_parse_user_group_strv_compat(0)load-fragment.c:2519→valid_user_group_name(RELAX):/whitespace, not./..Resolves #452. Stacked on #451 (batch 4).
Results — full burn-down summary
After batches 1-5 land,
OptionValueTest:July target reached. 🎉
Skipped
config_parse_exec_coredump_filter(0)— accepts filter names + arbitrary uint64, would loosen grammarconfig_parse_exec_selinux_context/smack_process_label(0)— context strings, deferconfig_parse_exec_root_hash{,_sig}(0)— base64-ish hashes, deferconfig_parse_{extension,mount,root_image_options,temporary_filesystems}_images(0)— path + mount-option syntax, deferconfig_parse_*_credential(0/1)— credential identifier + source, deferThese remain in the missing list for future batches.
Test plan
OptionValueTestandSemanticDataRepositoryTestpass🤖 Generated with Claude Code