You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tackling a few issues on the tracker.
Updating bokeh (and corresponding static js)
Making requirements.txt a specific pin to exactly match what is on reclaim host. Fixes#181 (commit typo, instead of #186 which doesn't exist yet); uses session instead of curdoc, so will work on multithreaded servers and doesn't have a weird inconsistent overlap with bokeh.
Solved the join.. on... sql queries which were making lists with duplicate column names; breaking the url generation. #170 is indeed reproduced in the simplest case of doing a full text search providing a spectra table with a bulk spectra download option added (as with the solo result page) Fixed#177 with the CAMD resetting behaviour to be more expected.
I launched a codespace to test this out and unfortunately got 404 errors on solo object results pages.
Just needed merging, this is because the SIMPLE-db upstream change had broken the website which was fixed by #188, all of which happened after this PR.
Testing out the bulk spectra download function (#170) I see that the filenames are changed. E.g., spex-prism_2MASSJ10073369-4555147_20061209_LOO07A.txt
gets downloaded as spectra_292_spex-prism_2MASSJ16150413%2B1340079_20060902_LOO07A.txt
Can you say why this spectra_##_ prefix is necessary?
Testing out the bulk spectra download function (#170) I see that the filenames are changed. E.g., spex-prism_2MASSJ10073369-4555147_20061209_LOO07A.txt gets downloaded as spectra_292_spex-prism_2MASSJ16150413%2B1340079_20060902_LOO07A.txt Can you say why this spectra_##_ prefix is necessary?
This is mostly to guarantee zero duplicates (e.g. same file name), which would break the code as it enters a python dictionary before being zipped, which as unique keys.
it's an awkward one: prove that an intermittent fault no longer occurs; I tested triggering the write spectra function a tonne of times and it had stopped randomly breaking.
bugSomething isn't workingenhancementNew feature or request
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tackling a few issues on the tracker.
Updating bokeh (and corresponding static js)
Making
requirements.txta specific pin to exactly match what is on reclaim host.Fixes #181 (commit typo, instead of #186 which doesn't exist yet); uses session instead of curdoc, so will work on multithreaded servers and doesn't have a weird inconsistent overlap with bokeh.
Solved the join.. on... sql queries which were making lists with duplicate column names; breaking the url generation.
#170 is indeed reproduced in the simplest case of doing a full text search providing a spectra table with a bulk spectra download option added (as with the solo result page)
Fixed #177 with the CAMD resetting behaviour to be more expected.