Skip to content

Conversation

@dr-rodriguez
Copy link
Collaborator

While checking if astrodbkit 2.2 would work, we realized that the website is using the deprecated version (astrodbkit2). This PR updates the code to use the new version and cleans up references to it.

It also updates the container and tests to Python 3.11.

@dr-rodriguez dr-rodriguez self-assigned this Feb 10, 2025
@dr-rodriguez dr-rodriguez requested a review from kelle February 10, 2025 20:59
@dr-rodriguez
Copy link
Collaborator Author

I noticed our ReclaimCloud server is running python 3.9.16. To update that, I think we need to re-configure the topology to get a new version of Apache with a newer python.

It's probably OK to stick with 3.9.16 for now. Technically 3.11 is required by astrodbkit now, but it's to support felis schemas.

That said, maybe this is an opportunity for us to upgrade to 3.11.11 in ReclaimCloud?

@Will-Cooper
Copy link
Member

I noticed our ReclaimCloud server is running python 3.9.16. To update that, I think we need to re-configure the topology to get a new version of Apache with a newer python.

That makes sense, I'm just hesitant to do it without plenty of time to work with, as it will almost undoubtedly break at first.

It's probably OK to stick with 3.9.16 for now. Technically 3.11 is required by astrodbkit now, but it's to support felis schemas.

That said, maybe this is an opportunity for us to upgrade to 3.11.11 in ReclaimCloud?

I think it's good practice to at least attempt to keep up with the curve, especially on a live site, even if just for security purposes. Would jumping ahead to 3.12 work?

Copy link
Member

@Will-Cooper Will-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes to simports, requirements, environment. I don't as closely understand the codeql and python-app changes (e.g. why python 3.11 not python 3.11.11), but the workflow actions run, so I think I'm happy.

@dr-rodriguez
Copy link
Collaborator Author

Kelle recommended waiting on updating python versions in Reclaim Cloud until something breaks, so for now we'll stick to 3.9. The 3.11 requirements are for Felis use which is something the web app doesn't need.

@dr-rodriguez dr-rodriguez merged commit adc74a6 into main Feb 11, 2025
1 check passed
@dr-rodriguez dr-rodriguez deleted the update-astrodbkit branch February 11, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants