-
Notifications
You must be signed in to change notification settings - Fork 25
Create SIMPLE Demos #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SIMPLE Demos #663
Conversation
|
@kelle QueryDemo.ipynb needs comments / notes on how to further improve the notebook! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR creates demonstration notebooks for the SIMPLE database project, specifically adding a visualization demo notebook that shows users how to visualize spectra and data from the database.
- Adds a new Jupyter notebook focused on visualizing spectra with SIMPLE
- Provides a structured template for demonstration purposes with placeholder sections
- Includes necessary imports for spectral data visualization and database querying
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
QueryDemo.ipynb
Outdated
| " ('CFBDS J022644.65-062522.0', 36.686, -6.4228, None, '2000', None, 'Albe11', None, None),\n", | ||
| " ('2MASS J05574102-1333264', 89.420954, -13.557334, None, None, None, 'Cruz18', None, 'not M'),\n", | ||
| " ('2MASS J09393548-2448279', 144.897834, -24.80775, None, None, '0939-2448', 'Tinn05.2326', None, None),\n", | ||
| " ('2MASS J22590210+1156035', 344.758944, 11.933929, None, None, None, 'Zhan18.2054', None, 'Discovery reference from t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not have this cell. You've shown how to use the Astrodbkit query methods and how to use sql_query, but now you're going into low-level API for SQLAlchemy itself. While useful, it probably doesn't belong in a notebook demonstrating quick/useful queries of SIMPLE.
QueryDemo.ipynb
Outdated
| " ('CFBDS J022644.65-062522.0', 36.686, -6.4228, None, '2000', None, 'Albe11', None, None),\n", | ||
| " ('2MASS J05574102-1333264', 89.420954, -13.557334, None, None, None, 'Cruz18', None, 'not M'),\n", | ||
| " ('2MASS J09393548-2448279', 144.897834, -24.80775, None, None, '0939-2448', 'Tinn05.2326', None, None),\n", | ||
| " ('2MASS J22590210+1156035', 344.758944, 11.933929, None, None, None, 'Zhan18.2054', None, 'Discovery reference from t |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this cell and the rest of the notebook. This is not a SQLAlchemy notebook, it is a SIMPLE notebook. It's also not a visualization notebook. I recommend removing the cells with the low-level sqlalchemy aspects and moving the visualization stuff to the other notebook (I haven't taken a look at that one yet).
|
Notes from SIMPLE Coworking:
|
kelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the QueryDemo notebook should be shorter. Move everything after "Have a more complex query? Let use astrodb_utils.sql_query to run a SQL query directly" to a separate notebook.
kelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new flow in the spectra notebook is good! It should stop after the nicely formatted figure with the three spectra. Everything after "Now lets try plotting spectra from multiple sources using a couple different metrics we can decide on within SIMPLE" should go into a separate notebook.
kelle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Short description: Moved from secret simple, two notebooks for querying the database and another for visualizing spectra and data.