Ingest modeled parameters sanghi23

[kaseyLee123]

Short description: Include what type of data being ingested and appropriate references.

Link to relevant issue: Closes #518 and Closes #484 .

For data ingests:
[ ] includes script used for ingest
[ ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table

[kelle]

This looks like great progress! Before adding new parameters, please add a test for the modeled parameters that counts the number of parameters with model = Null.

[kelle]

Also update with main. It shouldn't impact this PR since it's all photometry and proper motions.

[kaseyLee123]

I just edited pytest cases where I added one for checking which had a null value for model and also how many of each parameter was ingested (added one for L bol). I added counters in my script and have the number in the comments next to it and the pytest case numbers make sense when I do the math

[kaseyLee123]

Just pushed the new pytest file. I have the JSON files (a little over 1000) ready to push whenever

[kelle]

This if statement is not needed since we expect some parameters to not have models.

Suggested change

	if len(t) > 0:
	print("\nEntries found without a model")
	print(t)

[kelle]

Awesome progress!

• could you please try to push just 10-20 JSON files. If you're still using Github Desktop, use the checkboxes to Deselect All and then Select 10-20 by hand to add, commit, and push.
• add tests which test the references for the modeled paramaters. How many Lbols from Fili15?

[kaseyLee123]

Awesome progress!

• could you please try to push just 10-20 JSON files. If you're still using Github Desktop, use the checkboxes to Deselect All and then Select 10-20 by hand to add, commit, and push.
• add tests which test the references for the modeled paramaters. How many Lbols from Fili15?

Did you want the pytest case to check references for each parameter or just in general?

[kelle]

For each parameter. How many Lbols from Fili15? How many Lbols from Sang24?

[kelle]

Is there really a source name called "veryred-1527"? @cosmicoder, any insight on what source this is?

[cosmicoder]

Hi Kelle, that is an old internal name that accidentally propagated through. The source is PSO J243.9421+67.2075. Let me know if there are any others. They should be updated in the latest version of the UltracoolSheet

[kelle]

• Please get the tests to pass locally with the new JSON files and push the test.py files, but not all of the JSONs yet.
• Go ahead and also update the Versions.md. The new version will be 4.3.2025.10. You can guess a date. maybe Friday. :)

[kaseyLee123]

just did! Not sure if the pytest case is the most efficient way because it seems a little long but. Also, the csv files did not have a ref column so I just put sang23 for all of them.

[kelle]

Yep, this looks great. Once you ingest the one skipped source (PSO J243.9421+67.2075), go ahead and push the JSONs!

[kaseyLee123]

just pushed

[kelle]

I think this is done. Great work!!!

[kelle]

Ohhhh, adding the adopted column! Let's go ahead and do that now since you're already modifying the schema.

• Add the adopted column - set them all to Null or 0.
• We don't have to actually adopt any measurements at the moment -- that will be hard to decide!
• Add a test which counts the number of adopted measurements. Should be zero for this PR.

[kelle]

Let's tweak the schema a bit more and add the adopted column.

[kelle]

Also, take a look at the ModeledParameters ingest template spreadsheet. Let's make sure what you're doing here is reflected in that template.

[kelle]

Looking at the ingest template, let's also add the other_references column.

[kaseyLee123]

Just did everything looks good I think

[kelle]

Amazing fast work! You're knocking it out of the park!