-
Notifications
You must be signed in to change notification settings - Fork 25
Ingest calamari spt parallax #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lesliech1004
wants to merge
10
commits into
SIMPLE-AstroDB:main
Choose a base branch
from
lesliech1004:ingest_calamari_spt_parallax
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ingest calamari spt parallax #652
lesliech1004
wants to merge
10
commits into
SIMPLE-AstroDB:main
from
lesliech1004:ingest_calamari_spt_parallax
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingested 2 sources: Gl 337CD and Gl 417BC Ingested 64 spectral types. Added flag to ingest_spectral_types that ignores neighbors
kelle
reviewed
Jul 25, 2025
kelle
reviewed
Jul 25, 2025
kelle
reviewed
Jul 25, 2025
Contributor
Author
|
2mass j19073307+3015304 still has the wrong reference for the spectral type. There is no alternate reference provided in the google sheets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingest spectral types for Emily Calamari's samples of UCDs and their higher mass primaries. Also ingest the parallax for the Calamari samples.
Link to relevant issue: Closes #634
Closes #635
For data ingests:
includes script used for ingest
includes modified JSON files
Add new tests
Update the Versions table