Skip to content

Conversation

@kaseyLee123
Copy link
Contributor

Versions table looks slightly different than the other pr because this versions table had one more update than the previous

Link to relevant issue: Closes #614

For data ingests:
[ ] includes script used for ingest
[ ] includes modified JSON files
[ ] Add new tests
[ ] Update the Versions table

@kaseyLee123 kaseyLee123 self-assigned this Jul 16, 2025
@kelle
Copy link
Collaborator

kelle commented Jul 16, 2025

  • Use this code to write the JSON files but DO NOT add/commit/push them.
  • Run pytest and make sure the changes that need to be made make sense
  • push the modified test files to this branch

@kelle
Copy link
Collaborator

kelle commented Jul 17, 2025

Please include the output of the counters in the script as comments.

@kelle kelle changed the title ingest CATWISE (code only) ingest CATWISE Jul 23, 2025
@kelle
Copy link
Collaborator

kelle commented Jul 23, 2025

  • add the comment to reference the ultracoolsheet
  • add tests for the number of adopted proper motions from the relevant references for Maro21 (and maybe Gaia).

@kaseyLee123
Copy link
Contributor Author

I added comments to each of my ingests, edited pytest case checking propermotion references for maro 21, edited versions table

@kaseyLee123
Copy link
Contributor Author

I also made a new pytest that checks for adopted propermotion refs

Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. Great work!

@kelle kelle merged commit 4ec1648 into SIMPLE-AstroDB:main Jul 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ingest CATWISE data

2 participants