Ingest code for calamari sample spectral types, and parallax #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesliech1004
changed the title
lesliech1004
changed the title
Contributor
Author
|
waiting for sources and publications to be merged into db. |
* Update CodeSpace settings to use python 3.11 * Updating tests/checks to use 3.11 or later
* add python matrix, drop 3.10 * add simbad check * restrict action to upstream repo * remove internet check. format output * up to 3.11 --------- Co-authored-by: David Rodriguez <dr-rodriguez@users.noreply.github.com>
* Worked on Ingest Sources for BONES_Archive * Worked on publications and accessing the ADS keys * Changed csv file. Manuallly ingested ULAS J074431.30+283915.6. * Changed csv file. Correct bones_archive data * Updated JSON files and pytest cases. * remove unicode from Lupine paper * add and clean up test_data.py * JSON files * versions table update * add the version thing back __version__ --------- Co-authored-by: Kelle Cruz <kellecruz@gmail.com> Co-authored-by: Kasey Lee
* Initial commit with package and boilerplate yaml file * Adding placeholder test * Adding Publications table * Reworking conftest to use felis schema * Adding Telescopes * Adding Instruments * Adding Parameters * Adding PhotometryFilters * Adding Versions and Regimes * Adding Sources and Names * Adding Photometry * Adding Parallaxes and RadialVelocities * Adding ProperMotions * Adding SpectralTypes * Adding Gravities * Adding Spectra * Adding ModeledParameters and CompanionRelationships table * Fixing some misnamed columns * fix for Spectra foreign keys * Correcting implementation of compound foreign key in Spectra * Relaxing NOT NULL constraing in CompanionRelationships table * Fix sample source with invalid RA * Skipping tests involving database views * Some test improvements * Refactoring conftest to use load_astrodb * Refactor scheduled_checks to use conftest database * Removing schema tests as these would no longer be needed * Adding tests demonstrating manual view creation * Adding quick test for checking views * Adding script to automatically generate schema diagram * rename documentation/ to docs/ * make Description 2nd column * schema docs * remove extra headings * try adding emoji to required columns * remove Nullable column * add exclamation meaning. * try exclamation again * tweaks * Reworking ER-diagram to be called auto_schema.png and placed in docs/figures/ * Renaming simple.py to catch errors in usage * Update to schema for column lengths * Removing calls to simple.schema in our ingest scripts * Fix for some spectra tests * Fix for incorrect table being specified in spectral_types.py * format foreign keys and checks * remove handmade CompanionRelationships.md * Removing test for views * Moving ER-diagram generation script * Adding constraint for avoiding negative filter width * Add check to avoid negative parallaxes * Removing parallax validation * minor edits * Fix test error * Source table tweaks * revised schema docs * remove handmade Sources doc * Re-enabling test * Updating documentation with TOC file * Fixing path to files * Updating to use docs/README.md * instruments table docs * ModeledParameters * Parameters * ProperMotions * RadialVelocities * Names * SpectralTypes * Parallaxes * fix UCD * Gravities * UCD fix * Telescopes * add links to scripts * remove Views * Publications * Spectra and SpectralTypes * Photometry * PhotometryFilters * delete Spectrum.md * lint * typo * Adding missing indexes to some of the Lookup tables * underline primary keys * tweak * add underlines with <ins> instead of <u></u> in schema docs * adding eralchemy2 to docs in pyproject.toml file --------- Co-authored-by: kelle <kellecruz@gmail.com>
* Adding RotationalParameters table to schema * Updating documentation * Updating missing unit * Updating description * Removing UCD from adopted column for consistency with other instances in SIMPLE * Updating UCD for inclination angle
* add felis instructions * add updated ERD
* Ingesting Sources * Minor updates to Ingest script * Ingest Sources and Sources' Alt Names * add counters * Updates to tests * Adding json files * Updating YU2 Sources * Deleted old YU files * Update test * version update --------- Co-authored-by: kelle <kellecruz@gmail.com>
* Changes to Data Files * Ingest 2MASS J0415 * Update scripts/ingests/Ingest_2MASS_J0415_09.py Co-authored-by: Kelle Cruz <kellecruz@gmail.com> * Update scripts/ingests/Ingest_2MASS_J0415_09.py Co-authored-by: Kelle Cruz <kellecruz@gmail.com> * Update data/reference/Publications.json Co-authored-by: Kelle Cruz <kellecruz@gmail.com> * Update data/reference/Telescopes.json Co-authored-by: Kelle Cruz <kellecruz@gmail.com> * Updating Ingest.py * Changes to Test_Data * Updates 11/19 * Fixed small typo * updating test_data * Json Files with Updated Other Names --------- Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
* Ingesting Spectra for B24 * Improvements to ingest_spectra --------- Co-authored-by: Kelle Cruz <kellecruz@gmail.com>
* Ingest script for BONES spectral types * ingest_spectral_type improvements * Updated JSON files and pytest test cases --------- Co-authored-by: kelle <kellecruz@gmail.com>
…AstroDB#581) * Adding scripts and CSV files for converting and ingesting spectra. * improvements to ingest_spectra and Roth24 ingest script * spectra function improvements * json files * Version update --------- Co-authored-by: kelle <kellecruz@gmail.com>
* Update on 2MASS J04151954-0935066 * Fix * Add Photometry and Spectra * fix * add URL for Spectra JWST * update Version table
* Ingest Beil24 Photometry * save to db and json file * Fix test_photometry
* renamed sources and added companion relationships * Added new names to names table * Updated pytest cases * Added companion relationships into JSON files and added B and A as siblings * saved new data to database * Updated pytest cases
* Ingest code for missing star names for Hya06 * Fixed pytest cases and wrong magnitude error
* ingest companion parameters * update + new csv file * commented out unnecessary code * adding CompanionParameters and CompanionList tables to the schema * implement cruz's changes + unconsumed column for reference is fixed * updated schema+parameters.json, updated csv file * comment * companionlist script + further bug testing in parameters * removed unnecessary * added companion list to reference table to fix pytest error * updated companion list json file * edit the ingesting publication logic * finished script + updated json files!! * Revert "finished script + updated json files!!" This reverts commit ad484d3. * changes * publication unicode changed within * schema update * Revert "schema update" This reverts commit 2f2a179. * reingested companion list with changed schema * updated json files with no unicode * update test_data with companion_param cases * remove unnecessart spaces --------- Co-authored-by: kelle <kellecruz@gmail.com>
lesliech1004
force-pushed
the
ingest_calamari_spectral_types
branch
from
86c82a4 to
9e644a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ingest spectral types for Emily Calamari's samples of UCDs and their higher mass primaries. Also ingest the parallax for the Calamari samples.
Link to relevant issue: Closes #634
Closes #635
For data ingests:
includes script used for ingest
includes modified JSON files
Add new tests
Update the Versions table