Skip to content

Conversation

@ying2212
Copy link
Collaborator

@ying2212 ying2212 commented Jun 23, 2025

Short description: Include what type of data being ingested and appropriate references.

Link to relevant issue: #529

For data ingests:

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

@kelle
Copy link
Collaborator

kelle commented Jun 24, 2025

Great start with converting the spectra! My one suggestion at this point is to do the various instruments/modes separately. Right now, it looks like the wavelength units for "Xshooter_VIS" isn't quite right but "OSIRIS" looks good.

@kelle
Copy link
Collaborator

kelle commented Jun 26, 2025

The spectra are looking great! But it looks like there are still some spectra which are failing or being skipped. We need to figure out what's going on with those.

@ying2212
Copy link
Collaborator Author

I’m running into errors with ingesting access_url in the Spectra table, seems like it only accepts URL format, but I’m working with local FITS files. I asked Carolina, and she said SIMPLE bdnyc has cloud storage for the files. Should I pull them from there instead?

@ying2212
Copy link
Collaborator Author

ying2212 commented Jun 26, 2025

The spectra are looking great! But it looks like there are still some spectra which are failing or being skipped. We need to figure out what's going on with those.

I believe the failed file is a README file that is storing some reference info. For the skipped files are Xshooter instrument as I’m doing Xshooter and OSIRIS separately, and those skipped files have already been plotted up above!

@kelle
Copy link
Collaborator

kelle commented Jul 1, 2025

For the ORSIRS data, let's trim their wavelength ranges like so:

spectrum = Spectrum.read(file_path) 
if filename == "ULAS_J230443.30+093423.9_sdL0_OSIRIS_GTC63-13A_Primeval-IV.fits":
        spectrum = extract_region(spectrum, SpectralRegion(0.625*u.um, 0.98*u.um))
if filename == "ULAS_J141832.35+025323.0_sdL0_comb_OSIRIS_scombine_Primeval-IV.fits":
        spectrum = extract_region(spectrum, SpectralRegion(0.62*u.um, 0.975*u.um))
else:
        spectrum = extract_region(spectrum, SpectralRegion(0.54*u.um, 1.02*u.um))

@kelle kelle marked this pull request as draft July 25, 2025 20:02
@kelle
Copy link
Collaborator

kelle commented Jul 25, 2025

This PR is stuck on trying to figure out what to do with the spectra that need to be binned down in order to see the spectra well.

@kelle
Copy link
Collaborator

kelle commented Aug 15, 2025

We decided to just make two spectra, one binned and unbinned. New question: how to deal with duplicate metadata and primary keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants