Skip to content

Conversation

@lesliech1004
Copy link
Contributor

@lesliech1004 lesliech1004 commented Jun 13, 2025

Ingested missing names for Hya06 and photometric data from Gaia, WISE, and 2MASS.

Link to relevant issue: Closes #550

For data ingests:

  • includes script used for ingest

  • includes modified JSON files

  • Add new tests

  • Update the Versions table

@lesliech1004 lesliech1004 requested a review from kelle June 16, 2025 19:41
@lesliech1004 lesliech1004 force-pushed the missing_star_name_entries branch from 64129b5 to 0b531a4 Compare June 17, 2025 16:41
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@kelle kelle requested a review from canavarrete01 June 18, 2025 16:00
@kelle
Copy link
Collaborator

kelle commented Jun 18, 2025

@canavarrete01 , why don't you take a look and if you also approve, squash and merge.

Copy link
Contributor

@canavarrete01 canavarrete01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great! Great job @lesliech1004

@canavarrete01 canavarrete01 merged commit 7a86aa9 into SIMPLE-AstroDB:main Jun 24, 2025
3 checks passed
lesliech1004 added a commit to lesliech1004/SIMPLE-db that referenced this pull request Jul 23, 2025
* Ingest code for missing star names for Hya06

* Fixed pytest cases and wrong magnitude error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Star Name Entries

3 participants