Ingest Pan-STARRS photometry and Kinematics #625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelle
reviewed
Jun 12, 2025
Comment on lines
56
to
58
|
|
||
| inaccessible += 1 | ||
| logger.error(f"Unexpected error for {row['source']}: {e}") |
Collaborator
There was a problem hiding this comment.
should there be an else here?
kelle
reviewed
Jun 12, 2025
|
|
||
| for _, row in data.iterrows(): | ||
| try: | ||
| if(not pd.isna(row["gmag"])): |
Collaborator
There was a problem hiding this comment.
make a list of the column names and loop over them rather than having the code duplicated 6 times.
kelle
reviewed
Jun 12, 2025
Collaborator
There was a problem hiding this comment.
these ~ files should never be added to GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description: Include what type of data being ingested and appropriate references.
Link to relevant issue: #609
For data ingests: