data ingest WISE 1049 #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looking good! Great start! The new names also need to be in the Names table. You can use this function: |
kelle
reviewed
Jun 11, 2025
Collaborator
|
Awesome! Now try adding the relationships. |
Contributor
Author
|
Do I manually input the companion relationships in their JSON files? |
lesliech1004
added a commit
to lesliech1004/SIMPLE-db
that referenced
this pull request
Jul 23, 2025
* renamed sources and added companion relationships * Added new names to names table * Updated pytest cases * Added companion relationships into JSON files and added B and A as siblings * saved new data to database * Updated pytest cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename sources Luhman 16, Luhman 16A, Luhman 16B to WISE names and add companion relationships in WISE 1049.
Link to relevant issue: Closes #568
For data ingests:
includes script used for ingest
includes modified JSON files
Add new tests
Update the Versions table