Skip to content

remove alias mention from verify #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adarshm11 merged 3 commits into from
Jan 2, 2026
Merged

remove alias mention from verify #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b48cd
remove alias mention from verify
adarshm11 Jan 2, 2026
a3f3ec8
also fix which error is thrown for invalid api key
adarshm11 Jan 2, 2026
8663709
also fix the test that failed after last commit
adarshm11 Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions api/main_endpoints/routes/OfficeAccessCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ const {
SERVER_ERROR,
NOT_FOUND,
OK,
FORBIDDEN,
} = require('../../util/constants').STATUS_CODES;
const membershipState = require('../../util/constants').MEMBERSHIP_STATE;
const express = require('express');
Expand Down Expand Up @@ -83,10 +82,10 @@ router.get('/verify', async (req, res) => {

if (apiKey !== API_KEY) {
writeLogToClient(req.method, {
statusCode: FORBIDDEN,
statusCode: UNAUTHORIZED,
message: `Invalid API key: ${apiKey}`,
});
return res.sendStatus(FORBIDDEN);
return res.sendStatus(UNAUTHORIZED);
}

const cardVerification = await verifyCard(cardBytes);
Expand Down
3 changes: 1 addition & 2 deletions api/main_endpoints/util/OfficeAccessCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ function verifyCard(cardBytes) {
return resolve(false);
}
if (!result) {
const description = cardBytes !== null ? cardBytes : alias;
logger.info(`Card: ${description} not found in the database`);
logger.info(`Card: ${cardBytes} not found in the database`);
}
return resolve(result); // return the document
});
Expand Down
5 changes: 2 additions & 3 deletions test/api/OfficeAccessCard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const {
UNAUTHORIZED,
NOT_FOUND,
SERVER_ERROR,
FORBIDDEN,
} = require('../../api/util/constants').STATUS_CODES;
const {
initializeTokenMock,
Expand Down Expand Up @@ -125,14 +124,14 @@ describe('OfficeAccessCard', () => {
expect(result).to.have.status(BAD_REQUEST);
});

it('Should return 403 with invalid api key', async () => {
it('Should return 401 with invalid api key', async () => {
const params = new URLSearchParams();
params.append('cardBytes', VALID_CARD_BYTES);
const path = VERIFY_API_PATH + '?' + params.toString();
const invalidApiKey = API_KEY + '-invalid-suffix';
const result = await test.sendGetRequestWithApiKey(
invalidApiKey + '', path);
expect(result).to.have.status(FORBIDDEN);
expect(result).to.have.status(UNAUTHORIZED);
});

it('Should return 404 with valid api key and unknown card', async () => {
Expand Down