fix: pin opentelemetry-instrumentation-langchain and add telemetry integration tests#143
Merged
Merged
Conversation
cassiofariasmachado
left a comment
cassiofariasmachado
left a comment
Member
There was a problem hiding this comment.
Nice work so far!
The old lock file had a corrupted importlib-metadata entry that caused uv to fail with "missing source field but has more than one matching package".
This reverts commit 6bd88b6.
# Conflicts: # uv.lock
Lift State TypedDict to module level so ty can see it satisfies StateGraph's type bound. Remove now-stale ignore comments in DMS tests.
ty cannot verify that TypedDict subclasses satisfy the TypedDictLikeV1 protocol, causing a false positive. Switching to a dataclass satisfies the DataclassLike protocol bound that ty can check statically.
LucasAlvesSoares
changed the title
cassiofariasmachado
previously approved these changes
Jun 5, 2026
cassiofariasmachado
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added integration tests for the telemetry module. Tests add a second exporter (in-mem) to autoinstrumentation, so that whatever goes inside can be verified and cleaned for other tests later on. It also adds a test agent that triggers auto_instrument in order to try and replicate what happens In a real-world scenario. BDD scenarios then focus on specifying parent-child relationships in traces and required attributes.
It required a change in the CI because, since we use the AICORE_* pattern from set_aicore_config(), we need to be able to inject env vars from secrets using that pattern.
Also bumped opentelemetry-instrumentation-langchain to >= 0.61.0 for compatibility and bumped PyJWT to fix a security issue.
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
uv run pytest tests/core/integration/telemetry -v
Checklist
Before submitting your PR, please review and check the following: