refactor: fix extension tool call#115
Closed
mudit777 wants to merge 7 commits into
Closed
Conversation
…m call_extension_tool
sophiaabi
approved these changes
May 15, 2026
mheidinger
approved these changes
May 18, 2026
tiagoek
reviewed
May 18, 2026
tiagoek
reviewed
May 18, 2026
tiagoek
reviewed
May 18, 2026
tiagoek
approved these changes
May 20, 2026
Resolve version conflict while integrating telemetry extension tool call refactor.
15 tasks
Contributor
Contributor
|
merged via #132 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplify
call_extension_tool()signature by removing theextension_nameandtool_prefixparameters. Thetool_nameargument is now used directly as the lookup key insource_mapping(no more prefix reconstruction), and the fallback extension name defaults tounknowninternally viaresolve_source_info().Related Issue
Closes #<issue_number>
(Link to the GitHub issue this PR addresses)
Type of Change
Please check the relevant option:
How to Test
Describe how reviewers can test your changes:
Checklist
Before submitting your PR, please review and check the following:
Breaking Changes
If this PR introduces breaking changes, please describe:
Callers who previously passed only
extension_name(without a matchingsource_mappingentry) will now seeunknowninsap.extension.extensionNamespan attributes, instead of the previously provided extension name.Additional Notes
Downstream consumers need corresponding updates to remove
extension_nameandtool_prefixfrom theircall_extension_tool()call sites