Conversation
So far, we used the `globalAccountId` of the provider along with the `btpAppName` to uniquely identify the app. This was however not right as the `globalAccountId` in the subscription payload may not be from the provider, hence there was no way to uniquely identify the app! To support such scenarios, we now introduce the `providerSubaccountId` within CAPApplication spec, as this is also part of the subscription payload, it now enables us to uniquely identify the app properly. _Going foward, we will most likely deprecate the `globalAccountId` and use `providerSubaccountId` exclusively to uniquely identify apps._
Pavan-SAP
requested review from
anirudhprasad-sap,
cbarbian-sap and
skrishnan-sap
|
Pavan-SAP
added
the
build-pr-images
Member
Author
|
To test this we need to apply CRDS from: we need images from: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we used the provider's
globalAccountIdandbtpAppNameto identify an app.This approach was not reliable because the
globalAccountIdin the subscription payload might not belong to the provider, making it impossible to uniquely identify the app.To solve this, we now introduce
providerSubaccountIdin the CAPApplication spec. This value is included in the subscription payload and along withbtpAppNameallows us to uniquely and correctly identify the app.Eventually, we plan to deprecate
globalAccountIdand replace it withproviderSubaccountIdin CAPApplication spec.