Skip to content

feat: automated javadoc generation with artifact upload#844

Merged
n-o-u-r-h-a-n merged 39 commits intomainfrom
fixing-javadoc
May 6, 2026
Merged

feat: automated javadoc generation with artifact upload#844
n-o-u-r-h-a-n merged 39 commits intomainfrom
fixing-javadoc

Conversation

@n-o-u-r-h-a-n
Copy link
Copy Markdown
Contributor

@n-o-u-r-h-a-n n-o-u-r-h-a-n commented Apr 28, 2026

Context

AI/ai-sdk-java-backlog#329.

Implemented a workflow which could be used for automatic javadoc generation by artifact upload.
Here is the link to the successful continuous integration run where I tested the new workflow (javadoc.yaml) by calling it inside continuous integration.

Feature scope:

  • Added the new workflow file named javadoc.yaml
  • Integrated javadoc.yaml inside prepare-release workflow as well as perform release to create a PR with uploaded Aggregated JavaDoc artifact and update the JavaDocs on the documentation portal upon each version release of the SDK.

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall approach of using the bash script maybe is a very good alternative to using the plugins we had before. But I think to make it easier to maintain in the future we should add way more explanatory comments about what is actually happening.
Besides that I found some things worth checking but like the overall approach!

Comment thread .github/workflows/javadoc.yaml Outdated
Comment thread .github/workflows/javadoc.yaml Outdated
Comment thread .github/workflows/javadoc.yaml
Comment thread .github/workflows/javadoc.yaml Outdated
Comment thread .github/workflows/javadoc.yaml Outdated
@Jonas-Isr
Copy link
Copy Markdown
Member

This looks good :)

What is now missing is to call this workflow from the prepare-release workflow and to upload the generated files into our docs. For that we need

  1. an additional step in your new workflow to create a PR on the AI SDK docs repo with the newly created javadocs. This will be very close to what happens also in the same workflow of the Cloud SDK,
  2. an additional step in the prepare-release workflow to call your new workflow. This should be very similar to how this is called in the same workflow of the Cloud SDK repo,
  3. a note in the PR created in the prepare-release workflow that the new javadoc PR needs to be reviewed and approved (exactly like in Cloud SDK),
  4. two additional steps in the perform release workflow to merge the new javadoc PR. This should be very similar to how this is done in Cloud SDK here and here.

This looks like a long list but it should be very close to what happens already in the Cloud SDK.

Comment thread .github/workflows/javadoc.yaml Fixed
n-o-u-r-h-a-n and others added 3 commits May 5, 2026 17:23
…ntain permissions'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@n-o-u-r-h-a-n n-o-u-r-h-a-n requested a review from Jonas-Isr May 5, 2026 15:36
@n-o-u-r-h-a-n
Copy link
Copy Markdown
Contributor Author

This looks good :)

What is now missing is to call this workflow from the prepare-release workflow and to upload the generated files into our docs. For that we need

  1. an additional step in your new workflow to create a PR on the AI SDK docs repo with the newly created javadocs. This will be very close to what happens also in the same workflow of the Cloud SDK,
  2. an additional step in the prepare-release workflow to call your new workflow. This should be very similar to how this is called in the same workflow of the Cloud SDK repo,
  3. a note in the PR created in the prepare-release workflow that the new javadoc PR needs to be reviewed and approved (exactly like in Cloud SDK),
  4. two additional steps in the perform release workflow to merge the new javadoc PR. This should be very similar to how this is done in Cloud SDK here and here.

This looks like a long list but it should be very close to what happens already in the Cloud SDK.

Do I need to update documentation and release notes?

@Jonas-Isr
Copy link
Copy Markdown
Member

Do I need to update documentation and release notes?

Yes, good idea! How about a line like "- Aggregated JavaDocs are published now on our documentation portal" under Improvements?

Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only very minor points!

Comment thread .github/workflows/javadoc.yaml
Comment thread .github/workflows/javadoc.yaml
n-o-u-r-h-a-n and others added 2 commits May 6, 2026 14:35
Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
@n-o-u-r-h-a-n
Copy link
Copy Markdown
Contributor Author

Do I need to update documentation and release notes?

Yes, good idea! How about a line like "- Aggregated JavaDocs are published now on our documentation portal" under Improvements?

Sounds nice! I added it!

Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@n-o-u-r-h-a-n n-o-u-r-h-a-n merged commit fc92c67 into main May 6, 2026
9 checks passed
@n-o-u-r-h-a-n n-o-u-r-h-a-n deleted the fixing-javadoc branch May 6, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants