Skip to content

chore: (DevOps) Improve spec-update workflow#748

Open
Jonas-Isr wants to merge 20 commits intomainfrom
improve-spec-update-workflow
Open

chore: (DevOps) Improve spec-update workflow#748
Jonas-Isr wants to merge 20 commits intomainfrom
improve-spec-update-workflow

Conversation

@Jonas-Isr
Copy link
Member

@Jonas-Isr Jonas-Isr commented Feb 5, 2026

Context

This PR improves the behaviour of our spec update workflow.

Background
We had the case before where a branch on the grounding repo was breaking the spec (resulting in a failed SDK check) but then simply committed something onto the branch without any spec changes. This led to the SDK check turning green, as the check only considered the most recent commit which did not have any spec changes and therefor skipped generation on our side.

To solve this, the workflow now checks for previous runs (from the same feature branch, using the run-name option as a filter) when no spec changes are detected. The logic when no spec changes detected is as follows:

  • if there is no previous run, current run succeeds,
  • if there is a previous run, current run succeeds if and only if the previous run succeeded.

Refer to the following 2 branches on the orch-repo for tests of this workflow.

Feature scope:

  • improve workflow
  • test it with orchestration spec changes

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@Jonas-Isr Jonas-Isr self-assigned this Feb 5, 2026
@Jonas-Isr Jonas-Isr changed the title chore: Improve spec-update workflow chore: (DevOps) Improve spec-update workflow Feb 6, 2026
@Jonas-Isr Jonas-Isr marked this pull request as ready for review February 6, 2026 12:09
@Jonas-Isr Jonas-Isr added the please-review Request to review a pull-request label Feb 6, 2026
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test runs look good. The weekly update should work this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants