-
Notifications
You must be signed in to change notification settings - Fork 160
Use CAP Java 4.0.2, cds-dk ^9 and cds-mtxs ^3 #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Let's update consistently to cds9 CAP Java 4 in a single PR. And let's also make sure we remove properties that are now set to the default. |
yes, this PR is not finished yet ;-) |
|
Ah sorry, I always get notifications for all PRs created in this repository. I thought you already added me as reviewer ;) |
|
Just as a hint: You can also take changes in #484 into account and merge that into this one. |
beckermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also check the application.yaml. There are likely some properties, which are no longer required, as they are defaults now.
I did a look into the |
..it is now enabled by default
| enabled: true | ||
| cds: | ||
| errors: | ||
| default-translations.enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I searched for defaultTranslations and not default-translations. I hate these different formats for the spring properties.
This PR updates the Bookshop to new major versions of several CAP components:
It also adopts new default values for configuration parameters and removes outdated settings:
.cdsrc.json:sql.native_hana_associations: false-> new default in cds ^9cdsc.newParser: true-> new default in cdsc ^6mtx/sidecar/package.json: