Skip to content

Conversation

@mofterdinger
Copy link
Member

@mofterdinger mofterdinger commented Jun 6, 2025

This PR updates the Bookshop to new major versions of several CAP components:

  • CAP Java 4.0.2
  • @sap/cds-dk ^9
  • @sap/cds ^9
  • @sap/cds-compiler ^6
  • @sap/cds-mtxs ^3

It also adopts new default values ​​for configuration parameters and removes outdated settings:

  • removed from .cdsrc.json:
    • sql.native_hana_associations: false -> new default in cds ^9
    • cdsc.newParser: true -> new default in cdsc ^6
  • removed from mtx/sidecar/package.json:
     "[development]": {
        "requires": { "auth": "dummy" }
      }
    

@beckermarc
Copy link
Contributor

beckermarc commented Jun 6, 2025

Let's update consistently to cds9 CAP Java 4 in a single PR. And let's also make sure we remove properties that are now set to the default.

@mofterdinger
Copy link
Member Author

Let's update consistently to cds9 CAP Java 4 in a single PR. And let's also make sure we remove properties that are now set to the default.

yes, this PR is not finished yet ;-)

@beckermarc
Copy link
Contributor

Ah sorry, I always get notifications for all PRs created in this repository. I thought you already added me as reviewer ;)

@mofterdinger mofterdinger marked this pull request as draft June 6, 2025 10:05
@beckermarc
Copy link
Contributor

beckermarc commented Jun 6, 2025

Just as a hint: You can also take changes in #484 into account and merge that into this one.

@mofterdinger mofterdinger changed the title Use CAP Java 4.0.2 Use CAP Java 4.0.2, cds-dk ^9 and cds-mtxs ^3 Jun 6, 2025
@mofterdinger mofterdinger marked this pull request as ready for review June 6, 2025 10:13
@mofterdinger mofterdinger requested a review from beckermarc June 6, 2025 10:14
Copy link
Contributor

@beckermarc beckermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also check the application.yaml. There are likely some properties, which are no longer required, as they are defaults now.

@mofterdinger
Copy link
Member Author

I think we should also check the application.yaml. There are likely some properties, which are no longer required, as they are defaults now.

I did a look into the application.yaml and in our migration guide 3 -> 4 and it looks like, no changes are required in application.yaml

@mofterdinger mofterdinger requested a review from beckermarc June 6, 2025 11:25
..it is now enabled by default
@beckermarc beckermarc merged commit e710625 into main Jun 6, 2025
2 checks passed
@beckermarc beckermarc deleted the cap_java_4 branch June 6, 2025 12:37
enabled: true
cds:
errors:
default-translations.enabled: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I searched for defaultTranslations and not default-translations. I hate these different formats for the spring properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants