Skip to content

Simplify notes mashup model #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beckermarc merged 1 commit into from
Apr 9, 2025
Merged

Simplify notes mashup model #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions srv/notes-mashup.cds
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,16 @@ using { API_BUSINESS_PARTNER } from './external/API_BUSINESS_PARTNER';
/**
* Simplified view on external addresses, which is used as an association target in Notes.
*/
entity my.bookshop.NoteableAddresses as select from API_BUSINESS_PARTNER.A_BusinessPartnerAddress mixin {
// bi-directional association
notes : Composition of many bookshop.Notes on notes.address.businessPartner = $projection.businessPartner and notes.address.ID = $projection.ID
} into {
entity my.bookshop.NoteableAddresses as projection on API_BUSINESS_PARTNER.A_BusinessPartnerAddress {
key AddressID as ID,
key BusinessPartner as businessPartner,
@readonly Country as country,
@readonly CityName as city,
@readonly PostalCode as postalCode,
@readonly StreetName as street,
@readonly HouseNumber as houseNumber,
notes @(odata.contained: false)
@odata.contained: false notes : Composition of many bookshop.Notes
on notes.address.businessPartner = $self.businessPartner and notes.address.ID = $self.ID
};

/*
Expand Down
1 change: 0 additions & 1 deletion srv/src/main/java/my/bookshop/handlers/AdminServiceHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import com.sap.cds.services.ErrorStatuses;
import com.sap.cds.services.EventContext;
import com.sap.cds.services.ServiceException;
import com.sap.cds.services.cds.CdsReadEventContext;
import com.sap.cds.services.cds.CdsUpdateEventContext;
import com.sap.cds.services.cds.CqnService;
import com.sap.cds.services.draft.DraftCancelEventContext;
Expand Down