Skip to content

Conversation

@StefanHenke
Copy link
Contributor

@cds/cds does not yet support express in version 5. The previous dependabot upgrade broke the BTP integration tests with the following error. Switching back to version 4.

While resolving: @sap/cds@8.9.1

[2025-04-09T06:46:54.506Z] npm error Found: express@5.1.0
[2025-04-09T06:46:54.506Z] npm error node_modules/express
[2025-04-09T06:46:54.506Z] npm error   express@"^5" from the root project
[2025-04-09T06:46:54.506Z] npm error   peer express@">=4" from @sap/cds-fiori@1.4.1
[2025-04-09T06:46:54.506Z] npm error   node_modules/@sap/cds/node_modules/@sap/cds-fiori
[2025-04-09T06:46:54.506Z] npm error     @sap/cds-fiori@"^1" from @sap/cds@8.9.1
[2025-04-09T06:46:54.506Z] npm error
[2025-04-09T06:46:54.506Z] npm error Could not resolve dependency:
[2025-04-09T06:46:54.506Z] npm error peerOptional express@"^4" from @sap/cds@8.9.1
[2025-04-09T06:46:54.506Z] npm error node_modules/@sap/cds
[2025-04-09T06:46:54.506Z] npm error   @sap/cds@"^8" from the root project
[2025-04-09T06:46:54.506Z] npm error   peer @sap/cds@">=7.9" from @cap-js/db-service@1.19.1
[2025-04-09T06:46:54.506Z] npm error   node_modules/@cap-js/db-service
[2025-04-09T06:46:54.506Z] npm error     @cap-js/db-service@"^1.19.0" from @cap-js/hana@1.8.1
[2025-04-09T06:46:54.506Z] npm error     node_modules/@cap-js/hana
[2025-04-09T06:46:54.506Z] npm error       @cap-js/hana@"^1" from the root project
[2025-04-09T06:46:54.506Z] npm error     1 more (@cap-js/sqlite)
[2025-04-09T06:46:54.506Z] npm error   3 more (@cap-js/hana, @cap-js/sqlite, @sap/cds-fiori)
[2025-04-09T06:46:54.506Z] npm error
[2025-04-09T06:46:54.506Z] npm error Conflicting peer dependency: express@4.21.2
[2025-04-09T06:46:54.506Z] npm error node_modules/express
[2025-04-09T06:46:54.506Z] npm error   peerOptional express@"^4" from @sap/cds@8.9.1
[2025-04-09T06:46:54.506Z] npm error   node_modules/@sap/cds
[2025-04-09T06:46:54.506Z] npm error     @sap/cds@"^8" from the root project
[2025-04-09T06:46:54.506Z] npm error     peer @sap/cds@">=7.9" from @cap-js/db-service@1.19.1
[2025-04-09T06:46:54.506Z] npm error     node_modules/@cap-js/db-service
[2025-04-09T06:46:54.506Z] npm error       @cap-js/db-service@"^1.19.0" from @cap-js/hana@1.8.1
[2025-04-09T06:46:54.506Z] npm error       node_modules/@cap-js/hana
[2025-04-09T06:46:54.506Z] npm error         @cap-js/hana@"^1" from the root project
[2025-04-09T06:46:54.506Z] npm error       1 more (@cap-js/sqlite)
[2025-04-09T06:46:54.506Z] npm error     3 more (@cap-js/hana, @cap-js/sqlite, @sap/cds-fiori)

@StefanHenke StefanHenke merged commit ec7e7c2 into main Apr 9, 2025
2 checks passed
@StefanHenke StefanHenke deleted the revert-express-upgrade branch April 9, 2025 07:20
@beckermarc
Copy link
Contributor

I think we need to define a dependabot rule then to avoid this update.

@StefanHenke
Copy link
Contributor Author

I think we need to define a dependabot rule then to avoid this update.

Makes sense. Let me try this...

@mofterdinger
Copy link
Member

sorry, I was a bit faster: #468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants