Fixed a potential memory leak risk in MemoryStreamExtension.Write#562
Open
Vincent-X-Zhang wants to merge 1 commit intoS7NetPlus:mainfrom
Open
Fixed a potential memory leak risk in MemoryStreamExtension.Write#562Vincent-X-Zhang wants to merge 1 commit intoS7NetPlus:mainfrom
MemoryStreamExtension.Write#562Vincent-X-Zhang wants to merge 1 commit intoS7NetPlus:mainfrom
Conversation
|
这是来自”麦冬@广西机械工业研究院”的邮箱自动回复邮件。您好，您的邮件已收到，我查阅后尽快回复您。
|
gfoidl
reviewed
Feb 19, 2026
| } | ||
| finally | ||
| { | ||
| ArrayPool<byte>.Shared.Return(buffer); |
Collaborator
There was a problem hiding this comment.
The try-finally is actually not what one wants here. See dotnet/runtime#48257 (reply in thread) and the following comments.
Thanks for trying to address a problem anyway!
But I'd recommend to close this PR due the reasons mentioned in the link above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the function
ArrayPool<byte>.Shared.Returnto the finally block.