ctutils: split CtAssign out of CtSelect [BREAKING]
#1363
Merged
+198
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: version bumped to v0.4.0-pre to denote breaking change (not for release) Extracts the `ct_assign` method into its own trait. The main advantage of this is the `CtSelect` trait requires a `Sized` bound, where an independent `CtAssign` trait does not, which means it can be impl'd for slices as a sort of conditional `copy_from_slice`. The main disadvantage is we lose the default implementation, so it becomes one more trait to impl. There's no good way to blanket impl one in terms of the other that won't preclude efficient implementations in some way or another, so this opts not to do that for maximum flexibility. To preserve `subtle`-like ergonomics where `CtSelect` means we can `CtAssign` as well, this bounds `CtSelect` on `CtAssign`. Finally, the same treatment is given to the `Bytes*` traits, with a `BytesCtAssign` split out of `BytesCtSelect` for parity, and an impl of `BytesCtAssign` for `[u8]` has been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: version bumped to v0.4.0-pre to denote breaking change (not for release)
Extracts the
ct_assignmethod into its own trait. The main advantage of this is theCtSelecttrait requires aSizedbound, where an independentCtAssigntrait does not, which means it can be impl'd for slices as a sort of conditionalcopy_from_slice.The main disadvantage is we lose the default implementation, so it becomes one more trait to impl. There's no good way to blanket impl one in terms of the other that won't preclude efficient implementations in some way or another, so this opts not to do that for maximum flexibility.
To preserve
subtle-like ergonomics whereCtSelectmeans we canCtAssignas well, this boundsCtSelectonCtAssign.Finally, the same treatment is given to the
Bytes*traits, with aBytesCtAssignsplit out ofBytesCtSelectfor parity, and an impl ofBytesCtAssignfor[u8]has been added.