Skip to content

ctutils: impl From<u8> for Choice #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Dec 29, 2025
Merged

ctutils: impl From<u8> for Choice #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ctutils/src/choice.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ impl Choice {
///
/// # Panics
/// - in `debug` builds, panics if the value is anything other than `0` or `1`.
// TODO(tarcieri): deprecate this in favor of non-panicking constructors?
#[inline]
pub const fn new(value: u8) -> Self {
// Compare to what should be the non-secret upper bits of the value, which should always be
Expand Down Expand Up @@ -388,6 +389,17 @@ impl CtSelect for Choice {
}
}

/// Create a new [`Choice`] from the given `u8` value, which MUST be either `0` or `1`.
///
/// # Panics
/// - in `debug` builds, panics if the value is anything other than `0` or `1`.
// TODO(tarcieri): deprecate this in favor of non-panicking constructors?
impl From<u8> for Choice {
fn from(value: u8) -> Self {
Choice::new(value)
}
}

impl From<Choice> for u8 {
fn from(choice: Choice) -> u8 {
choice.to_u8()
Expand Down