Skip to content

cmov: address truncation lint for Cmov impl for u8 #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Dec 28, 2025
Merged

cmov: address truncation lint for Cmov impl for u8 #1302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cmov/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,21 +70,21 @@ pub trait CmovEq {
}
}

// TODO(tarcieri): address truncation lint
#[allow(clippy::cast_possible_truncation)]
impl Cmov for u8 {
#[inline]
fn cmovnz(&mut self, value: &Self, condition: Condition) {
let mut tmp = *self as u16;
tmp.cmovnz(&(*value as u16), condition);
*self = tmp as u8;
debug_assert!(tmp <= u8::MAX as u16);
*self = (tmp & 0xFF) as u8;
}

#[inline]
fn cmovz(&mut self, value: &Self, condition: Condition) {
let mut tmp = *self as u16;
tmp.cmovz(&(*value as u16), condition);
*self = tmp as u8;
debug_assert!(tmp <= u8::MAX as u16);
*self = (tmp & 0xFF) as u8;
}
}

Expand Down