cmov: fix truncation bug in portable implementation #1300
Merged
+14
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #1298 The previous portable implementation truncated integers when comparing them in the `u64` implemenation of `CmovEq`. This adds a macro adapted from `ctutils` and uses it everywhere 64-bit integers are being compared in the portable implementation.
tarcieri
added a commit
that referenced
this pull request
Dec 28, 2025
Issues like #1300 could ideally be caught via more fastidious linting. This adds several additional lints and TODOs to address the ones which are currently failing.
tarcieri
added a commit
that referenced
this pull request
Dec 28, 2025
Issues like #1300 could ideally be caught via more fastidious linting. This adds several additional lints and TODOs to address the ones which are currently failing.
tarcieri
added a commit
that referenced
this pull request
Dec 28, 2025
Issues like #1300 could ideally be caught via more fastidious linting. This adds several additional lints and TODOs to address the ones which are currently failing.
Merged
tarcieri
added a commit
that referenced
this pull request
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1298
The previous portable implementation truncated integers when comparing them in the
u64implemenation ofCmovEq.This adds a macro adapted from
ctutilsand uses it everywhere 64-bit integers are being compared in the portable implementation.